From 2d355ac6ec487575a0e13d132e0275c030bb0040 Mon Sep 17 00:00:00 2001 From: danibene <34680344+danibene@users.noreply.github.com> Date: Mon, 27 May 2024 22:13:34 -0400 Subject: [PATCH 1/3] change os tested for python 3.7 following https://github.com/actions/runner-images/issues/9770#issuecomment-2085623315 --- .github/workflows/ci.yml | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8c04bef..0775954 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -58,14 +58,16 @@ jobs: test: needs: prepare strategy: + fail-fast: false matrix: - python: - - "3.7" # oldest Python supported by PSF - - "3.12" # newest Python that is stable - platform: - - ubuntu-latest - - macos-latest - - windows-latest + python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"] + os: [ubuntu-latest, macos-latest, windows-latest] + exclude: # Python < v3.8 does not support Apple Silicon ARM64. + - python-version: "3.7" + os: macos-latest + include: # So run those legacy versions on Intel CPUs. + - python-version: "3.7" + os: macos-13 runs-on: ${{ matrix.platform }} steps: - uses: actions/checkout@v3 From 00b0e86c218f277e1e1e44a6f04bc0abcabd9fa4 Mon Sep 17 00:00:00 2001 From: danibene <34680344+danibene@users.noreply.github.com> Date: Mon, 27 May 2024 22:17:20 -0400 Subject: [PATCH 2/3] update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index be24ee5..2de1c9d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed - Updated `CONTRIBUTING.md` with more information on how to run the code checks. +- Changed the OS used to test Python 3.7 on GitHub actions (macos-latest -> macos-13). ### Removed From 102f73f135c74447aee9049e8a254eb6f66a856c Mon Sep 17 00:00:00 2001 From: danibene <34680344+danibene@users.noreply.github.com> Date: Mon, 27 May 2024 22:22:49 -0400 Subject: [PATCH 3/3] use variable names from previous version of ci file --- .github/workflows/ci.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0775954..2b77530 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -60,14 +60,14 @@ jobs: strategy: fail-fast: false matrix: - python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"] - os: [ubuntu-latest, macos-latest, windows-latest] + python: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12"] + platform: [ubuntu-latest, macos-latest, windows-latest] exclude: # Python < v3.8 does not support Apple Silicon ARM64. - - python-version: "3.7" - os: macos-latest + - python: "3.7" + platform: macos-latest include: # So run those legacy versions on Intel CPUs. - - python-version: "3.7" - os: macos-13 + - python: "3.7" + platform: macos-13 runs-on: ${{ matrix.platform }} steps: - uses: actions/checkout@v3