Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various #2

Open
akavel opened this issue Aug 29, 2013 · 0 comments
Open

Various #2

akavel opened this issue Aug 29, 2013 · 0 comments
Assignees

Comments

@akavel
Copy link

akavel commented Aug 29, 2013

Please, add info on average & worst complexity in godoc comments for each function.

Also, in godoc comments for "Insert" function, you refer to "MakeInvertedSuffix", which is not present - supposedly that was an old name and you mean the "New" function?

Also, you have lots of deeply nested ifs in your code - you could consider using 'continue' in ifs in loops, to ease reading.

Also, you have quite a few exact repetitions of big chunks of code, I strongly advise to seriously consider extracting them to functions, or please at least comment if that's as is because of Serious Optimizations Totally Backed By Measurements And Not Premature, otherwise (paired with the issue above) they make reading the codebase highly tedious and irritating.

thanks.

@ghost ghost assigned argusdusty Aug 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants