Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: GTW API support changed to Gloo Gateway instead of GloodMesh #3914

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

ilrudie
Copy link
Contributor

@ilrudie ilrudie commented Oct 25, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Copy link

@ilrudie
Copy link
Contributor Author

ilrudie commented Oct 25, 2024

I didn't file an issue since this is just a quick typo, please LMK if that is strictly required.

I did not add Solo.io to the users lists since we are building things which integrate with the argo ecosystem and I am not aware of any direct production use here.

@ilrudie ilrudie changed the title docs: GTW API support to changed to Gloo Gateway instead of GloodMesh docs: GTW API support changed to Gloo Gateway instead of GloodMesh Oct 25, 2024
Copy link
Contributor

Published E2E Test Results

  4 files    4 suites   3h 14m 34s ⏱️
113 tests 104 ✅  7 💤 2 ❌
454 runs  424 ✅ 28 💤 2 ❌

For more details on these failures, see this check.

Results for commit ad4a521.

Copy link
Contributor

Published Unit Test Results

2 278 tests   2 278 ✅  2m 59s ⏱️
  128 suites      0 💤
    1 files        0 ❌

Results for commit ad4a521.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.75%. Comparing base (1264f8d) to head (ad4a521).
Report is 73 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3914      +/-   ##
==========================================
+ Coverage   82.69%   82.75%   +0.06%     
==========================================
  Files         163      163              
  Lines       22886    22886              
==========================================
+ Hits        18925    18940      +15     
+ Misses       3087     3077      -10     
+ Partials      874      869       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaller zachaller merged commit 8696879 into argoproj:master Oct 29, 2024
27 checks passed
@ilrudie ilrudie deleted the fix-typo-gloo branch October 29, 2024 14:27
Rizwana777 pushed a commit to Rizwana777/argo-rollouts that referenced this pull request Dec 12, 2024
…rgoproj#3914)

correct GTW API support to state Gloo Gateway instead of GloodMesh

Signed-off-by: Ian Rudie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants