-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dashboard): improve pods visibility #3483
feat(dashboard): improve pods visibility #3483
Conversation
E2E Tests Published Test Results 4 files 4 suites 3h 43m 26s ⏱️ For more details on these failures, see this check. Results for commit d99b53c. ♻️ This comment has been updated with latest results. |
657ca90
to
c96740b
Compare
Go Published Test Results2 144 tests 2 144 ✅ 2m 51s ⏱️ Results for commit d99b53c. ♻️ This comment has been updated with latest results. |
This commit adds two improvements to the Pods view: * Show spinner (pending status) while the pod is not ready (like ArgoCD UI does) * Show the `ready` property on the tooltip Signed-off-by: Alejandro López Sánchez <[email protected]>
c96740b
to
d99b53c
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3483 +/- ##
==========================================
+ Coverage 81.83% 82.79% +0.95%
==========================================
Files 135 135
Lines 20688 17032 -3656
==========================================
- Hits 16931 14101 -2830
+ Misses 2883 2041 -842
- Partials 874 890 +16 ☔ View full report in Codecov by Sentry. |
This commit adds two improvements to the Pods view: * Show spinner (pending status) while the pod is not ready (like ArgoCD UI does) * Show the `ready` property on the tooltip Signed-off-by: Alejandro López Sánchez <[email protected]>
This commit adds two improvements to the Pods view:
ready
property on the tooltipThe motivation is that having them green is a bit confusing when they are not ready to serve traffic, especially during the step of
setWeight
in a canary.Some screenshots of the changes:
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.