Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granular control of weight when using traffic routing #2657

Open
mvgmb opened this issue Mar 14, 2023 · 3 comments
Open

Granular control of weight when using traffic routing #2657

mvgmb opened this issue Mar 14, 2023 · 3 comments

Comments

@mvgmb
Copy link
Contributor

mvgmb commented Mar 14, 2023

Summary

When using traffic routing with canary, the stable scale is always 100 - canary scale. This restricts the minimum percentage of routed traffic greater than zero to 1%. However, ingresses are capable of more granular control over traffic.

For example, AWS ALB allows weights from 0 to 999, enabling a minimum of ~0.1% (canaryWeight=1 stableWeight=999) to be routed to the canary.

To avoid issues related setStableScale in a canary step (#1029 (comment)), my proposition is to be able to set the stable scale initial weight. Therefore, the stable scale can still be dynamically scaled down as the canary scale is scaled up.

Use Cases

For example, setting the initial stable scale weight to 200, it'd allow me to route ~0.5% of the traffic to the canary:

spec:
  strategy:
    canary:
      stableInitialScale:
        weight: 200
      steps:
        - setWeight: 1 # canaryWeight=1 (~0.5%) stableScale=199 (~99.5%)
        - pause:
            duration: 5m
        - setWeight: 50 # canaryWeight=50 (25%) stableScale=150 (75%)
        - pause:
            duration: 5m

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@mvgmb mvgmb added the enhancement New feature or request label Mar 14, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@andyliuliming
Copy link
Contributor

I'm trying to resolve this in #3215

@kostis-codefresh
Copy link
Member

@mvgmb PR #3215 was merged. Does this solve your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants