Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A single rollout should support multiple Istio VirtualServices #1349

Closed
aweis89 opened this issue Jul 14, 2021 · 1 comment
Closed

A single rollout should support multiple Istio VirtualServices #1349

aweis89 opened this issue Jul 14, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@aweis89
Copy link
Contributor

aweis89 commented Jul 14, 2021

Summary

Currently the Argo Rollouts spec only supports a single VirtualService. This forces folks with multiple VirtualService's with the same destinations to chose which one to use for the canary rollout.

Use Cases

It's very common to have multiple VirtualService's pointing to a single backend service. One example where this is commonly needed is when associating a VirtualService with a Gateway. You often want separate URLs/hosts/rewrites for the Gateway VirtualService vs the VirtualService being used internally.

One of the nice things about using Istio for canary rollouts is that it enables canary for either internal or external traffic since the same VirtualService API can be used for either. While either type of virtual service currently works with Argo Rollouts, it would be ideal if there was an option to specify both the gateway virtual service and the internal one, even when they're separate resources. This would enable the canary rollout to apply to all traffic in such instances instead of forcing folks to chose.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

@aweis89 aweis89 added the enhancement New feature or request label Jul 14, 2021
@jessesuen
Copy link
Member

jessesuen commented Jul 14, 2021

Agree, but is a duplicate of #1100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants