Dashboard UI with namespace picker doesn't show individual rollout in other namespace

[gempesaw]

Summary

After #1291, it's possible to install the dashboard in one namespace and view Rollouts in another namespace. The main page which watches multiple Rollouts works fine and displays Rollouts in other namespaces. However, accessing the individual page for a Rollout in a different namespace shows an empty page.

The logs mention that the Rollout resource wasn't found. If I kubectl argo rollouts dashboard in the appropriate namespace, the "individual rollout page" works as expected.

From the UI, the namespace looks to be correct in the /watch request

but I notice in #1291 that WatchRolloutInfos was updated to get the context from the ws:

argo-rollouts/server/server.go

Line 295 in ba21c6c

ctx := ws.Context()

whereas WatchRolloutInfo is not accordingly updated, and still uses context.Background()

argo-rollouts/server/server.go

Lines 213 to 214 in ba21c6c

	func (s *ArgoRolloutsServer) WatchRolloutInfo(q *rollout.RolloutInfoQuery, ws rollout.RolloutService_WatchRolloutInfoServer) error {
	ctx := context.Background()

Diagnostics

I'm running dashboard docker image quay.io/argoproj/kubectl-argo-rollouts@sha256:c9d6c70161fa86aac4f9c0747049809c92e5b1d1356c0e62f3299d407f76c4ad, which was the SHA of "latest" from last week.

kubectl logs argo-rollouts-dashboard-b6dbf8898-c79zr --namespace=argo-rollouts --namespace=argo-rollouts

time="2021-07-09T04:12:47Z" level=info msg="Argo Rollouts Dashboard is now available at localhost 3100"
time="2021-07-09T04:30:21Z" level=warning msg="rollout.argoproj.io \"hello-pagey-argo-canary\" not found"
time="2021-07-09T04:30:27Z" level=warning msg="rollout.argoproj.io \"hello-pagey-argo-canary\" not found"
time="2021-07-09T04:30:37Z" level=warning msg="rollout.argoproj.io \"hello-pagey-argo-canary\" not found"
time="2021-07-09T04:36:05Z" level=warning msg="rollout.argoproj.io \"hello-pagey-argo-canary\" not found"
time="2021-07-09T13:28:40Z" level=warning msg="rollout.argoproj.io \"hello-pagey-argo-canary\" not found"
time="2021-07-09T13:28:45Z" level=warning msg="rollout.argoproj.io \"hello-pagey-argo-canary\" not found"
time="2021-07-09T13:48:52Z" level=warning msg="rollout.argoproj.io \"hello-pagey-argo-canary\" not found"
time="2021-07-09T13:48:59Z" level=warning msg="rollout.argoproj.io \"hello-pagey-argo-canary\" not found"
time="2021-07-09T13:50:52Z" level=warning msg="rollout.argoproj.io \"hello-pagey-argo-canary\" not found"

---

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.

[marcportabellaclotet-mt]

I am having the same issue.

level=warning msg="rollout.argoproj.io \"rollouts-demo\" not found"

I am able to browse namespaces where there are rollouts, but when clicking into it, it returns an empty page.

By the way, argo rollouts is an awesome product!!!

[jessesuen]

@perenesenko could you look into this?

[perenesenko]

Yes. I will look on it

[perenesenko]

PR #1344

[Cylix]

Hey @perenesenko, thanks for the fix!

Do you know when this fix is planned for an official release? It seems it is not part of the 1.0.4 and 1.0.5 releases, but it is present on the master branch (unless I missed something 😄 )

Thanks!

[bpoland]

I tried running master/latest images of both the rollouts controller and dashboard, but am still seeing this issue. Shouldn't it be fixed in those?

I do not see any warnings in the dashboard pod logs though, so maybe this is a different issue?

[bpoland]

Hmm I've been playing around with it some more and I think there's something about my Rollout that is causing it. Will update with more info/open a new issue if I can narrow it down.

[bpoland]

It's related to an ingress SSO solution that's in front of the dashboard, so ignore me.

For anyone also trying to use the dashboard with buzzfeed SSO, the flush_interval workaround here solved it for me: buzzfeed/sso#232