Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build environment should be available to kustomize #8317

Closed
jacekszlachtass opened this issue Jan 29, 2022 · 3 comments
Closed

Build environment should be available to kustomize #8317

jacekszlachtass opened this issue Jan 29, 2022 · 3 comments
Labels
component:config-management Tools specific issues (helm, kustomize etc) enhancement New feature or request type:usability Enhancement of an existing feature

Comments

@jacekszlachtass
Copy link

jacekszlachtass commented Jan 29, 2022

Summary

Build environment should be available to sources using kustomize.
At the moment this is not supported: https://argo-cd.readthedocs.io/en/stable/user-guide/kustomize/#build-environment

Motivation

It is possible to use env variables with kustomize, please see these links:
https://rm3l.org/using-system-envvars-with-kustomize/
https://kubernetes.io/docs/tasks/manage-kubernetes-objects/kustomization/#configmapgenerator
kubernetes/website#30348

Proposal

How do you think this should be implemented?

I have no idea how, but I am guessing this could be done the same way as for helm, jsonnet and custom tools.

@jacekszlachtass jacekszlachtass added the enhancement New feature or request label Jan 29, 2022
@jannfis jannfis added component:config-management Tools specific issues (helm, kustomize etc) type:usability Enhancement of an existing feature labels Feb 2, 2022
@jannfis
Copy link
Member

jannfis commented Feb 2, 2022

Maybe this could be extended to also set arbitrary environment variables for kustomize applications, instead of only passing build environment?

@alexmt
Copy link
Collaborator

alexmt commented Feb 3, 2022

This has been implemented already. Please see latest version of build environment documentation: https://argo-cd.readthedocs.io/en/latest/user-guide/build-environment/

@crenshaw-dev
Copy link
Member

Closing since the original use case is solved. Added an issue for Jann's suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:config-management Tools specific issues (helm, kustomize etc) enhancement New feature or request type:usability Enhancement of an existing feature
Projects
None yet
Development

No branches or pull requests

4 participants