From 803dd3dbcdb90845da7f87a431b5dd92d010c04c Mon Sep 17 00:00:00 2001
From: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Date: Mon, 3 Feb 2025 14:34:23 -0500
Subject: [PATCH] simplify

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
---
 util/db/repository.go | 20 +++++++-------------
 1 file changed, 7 insertions(+), 13 deletions(-)

diff --git a/util/db/repository.go b/util/db/repository.go
index 0beffa47878c8..9ff1d7eeef9dc 100644
--- a/util/db/repository.go
+++ b/util/db/repository.go
@@ -168,21 +168,15 @@ func (db *db) ListWriteRepositories(ctx context.Context) ([]*v1alpha1.Repository
 }
 
 func (db *db) listRepositories(ctx context.Context, repoType *string, writeCreds bool) ([]*v1alpha1.Repository, error) {
-	// TODO It would be nice to check for duplicates between secret and legacy repositories and make it so that
-	// 	repositories from secrets overlay repositories from legacys.
-
-	var repositories []*v1alpha1.Repository
-	var err error
+	var backend repositoryBackend
 	if writeCreds {
-		repositories, err = db.repoWriteBackend().ListRepositories(ctx, repoType)
-		if err != nil {
-			return nil, err
-		}
+		backend = db.repoWriteBackend()
 	} else {
-		repositories, err = db.repoBackend().ListRepositories(ctx, repoType)
-		if err != nil {
-			return nil, err
-		}
+		backend = db.repoBackend()
+	}
+	repositories, err := backend.ListRepositories(ctx, repoType)
+	if err != nil {
+		return nil, err
 	}
 	if err = db.enrichCredsToRepos(ctx, repositories); err != nil {
 		return nil, err