Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This is horrendously unportable. #45

Open
TApplencourt opened this issue Jun 21, 2023 · 0 comments
Open

This is horrendously unportable. #45

TApplencourt opened this issue Jun 21, 2023 · 0 comments

Comments

@TApplencourt
Copy link
Collaborator 

          This is horrendously unportable.
  • The spec defines __SYCL_DEVICE_ONLY__ only for SMCP compilers. For single-pass compilers, like the hipSYCL generic SSCP compiler, this is not defined in accordance with the SYCL spec
  • Just throwing whenever __SYCL_DEVICE_ONLY__ is not defined will completely break on any library-only host backend, where the kernel is compiled as part of the host pass for CPU.

You should seriously start looking into adding CI and validation for other compilers. That would make such issues blatantly obvious.

Originally posted by @illuhad in #41 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TApplencourt