You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This likely requires some changes to hipSYCL and some changes to the sycl_ext_complex header:
hipSYCL does not yet have isinf
the sycl::half define in hipSYCL does not support float operations
I suggest we have a define for disabling/enabling sycl::half. We could do this by having the user define e.g. 'SYCL_EXT_COMPLEX_DISABLE_HALFbefore the header, or do compiler detection and hard code, .e.g enable if__INTEL_CLANG_COMPILER` is set and disable otherwise, or disable just if a hipsycl define is present. I am more inclined towards the user define to disable it, more flexible and then we are not hardcoding version checks that may need to change.
The text was updated successfully, but these errors were encountered:
I think for sycl::half it's user's responsibility to check for aspect::fp16 before calling any API with half.
As Illuhad said, the type should be defined, so the code including our sycl::ext::complex should compile. Using it is a different story :). Or maybe I'm missing something!
the sycl::half define in hipSYCL does not support float operations
We have universal support for half and half arithmetic now across all backends and devices (even though it might be emulated if there's no native support), but we don't have half overloads for the sycl:: math functions yet. I'm not sure if that's a problem though as it might just implicitly convert to float and then invoke the float overload.
This likely requires some changes to hipSYCL and some changes to the sycl_ext_complex header:
isinf
sycl::half
define in hipSYCL does not support float operationsI suggest we have a define for disabling/enabling
sycl::half
. We could do this by having the user define e.g. 'SYCL_EXT_COMPLEX_DISABLE_HALFbefore the header, or do compiler detection and hard code, .e.g enable if
__INTEL_CLANG_COMPILER` is set and disable otherwise, or disable just if a hipsycl define is present. I am more inclined towards the user define to disable it, more flexible and then we are not hardcoding version checks that may need to change.The text was updated successfully, but these errors were encountered: