From 0afb4194b881b07cc9a0a0d6a2de3aeb7e60a186 Mon Sep 17 00:00:00 2001 From: per1234 Date: Mon, 14 Oct 2024 15:56:39 -0700 Subject: [PATCH] Remove unused job outputs from release workflows In a previous revision of the release workflows, the updated checksums were determined by the macOS notarization job and then passed to the subsequent job via job outputs. That approach was changed during a later refactoring, but the code that declares the job outputs was not removed at that time. The checksum job output declaration code is now unused (and unusable since the checksum determination and output definitions were removed) so it only makes the workflows more difficult to understand and maintain. For this reason, the vestigial code is hereby removed from the workflows. --- workflow-templates/publish-go-nightly-task.yml | 6 ------ workflow-templates/release-go-crosscompile-task.yml | 1 - workflow-templates/release-go-task.yml | 4 ---- 3 files changed, 11 deletions(-) diff --git a/workflow-templates/publish-go-nightly-task.yml b/workflow-templates/publish-go-nightly-task.yml index a1884b4e..c70356c8 100644 --- a/workflow-templates/publish-go-nightly-task.yml +++ b/workflow-templates/publish-go-nightly-task.yml @@ -73,11 +73,6 @@ jobs: name: Notarize ${{ matrix.build.folder-suffix }} runs-on: macos-latest needs: create-nightly-artifacts - - outputs: - checksum-darwin_amd64: ${{ steps.re-package.outputs.checksum-darwin_amd64 }} - checksum-darwin_arm64: ${{ steps.re-package.outputs.checksum-darwin_arm64 }} - permissions: contents: read @@ -165,7 +160,6 @@ jobs: gon "${{ env.GON_CONFIG_PATH }}" - name: Re-package binary - id: re-package working-directory: ${{ env.DIST_DIR }} # Repackage the signed binary replaced in place by Gon (ignoring the output zip file) run: | diff --git a/workflow-templates/release-go-crosscompile-task.yml b/workflow-templates/release-go-crosscompile-task.yml index a6301e3a..4b933e27 100644 --- a/workflow-templates/release-go-crosscompile-task.yml +++ b/workflow-templates/release-go-crosscompile-task.yml @@ -182,7 +182,6 @@ jobs: gon "${{ env.GON_CONFIG_PATH }}" - name: Re-package binary - id: re-package working-directory: ${{ env.DIST_DIR }} # Repackage the signed binary replaced in place by Gon (ignoring the output zip file) run: | diff --git a/workflow-templates/release-go-task.yml b/workflow-templates/release-go-task.yml index 16811aea..4db24318 100644 --- a/workflow-templates/release-go-task.yml +++ b/workflow-templates/release-go-task.yml @@ -80,9 +80,6 @@ jobs: name: Notarize ${{ matrix.build.folder-suffix }} runs-on: macos-latest needs: create-release-artifacts - outputs: - checksum-darwin_amd64: ${{ steps.re-package.outputs.checksum-darwin_amd64 }} - checksum-darwin_arm64: ${{ steps.re-package.outputs.checksum-darwin_arm64 }} permissions: contents: read @@ -172,7 +169,6 @@ jobs: gon "${{ env.GON_CONFIG_PATH }}" - name: Re-package binary - id: re-package working-directory: ${{ env.DIST_DIR }} # Repackage the signed binary replaced in place by Gon (ignoring the output zip file) run: |