-
-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.0.5 patch breaks @skip and @include directives in schema stitching #1159
Comments
Not having any directive support in addResolversToSchemas was protecting against default of no directives in mergeSchemas and adding back the default directives. Fix is within mergeSchemas to pass undefined instead of empty array when directive option is not enabled. |
Should be fixed in graphql-tools-fork. Let me know if you can if you have any issues. |
Any news about this issue? |
We recently released an alpha version of GraphQL Tools (#1308) that should fix the issue. Please update
Let us know if it solves the problem, we're counting for your feedback! :) |
Rolled into #1306 . |
After we have updated graphql-tools to 4.0.5:
![image](https://user-images.githubusercontent.com/1989823/60283876-e3186a80-9912-11e9-9ac2-1ddc75186fce.png)
@Skip and @include directives broke in schema stitching.
For example we had this query:
We get this:
![image](https://user-images.githubusercontent.com/1989823/60283948-09d6a100-9913-11e9-9998-e1d41e0097b1.png)
The text was updated successfully, but these errors were encountered: