Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add status label for cosmos_ibc_client_expiry metric #14

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

kayano
Copy link
Contributor

@kayano kayano commented Sep 25, 2023

It allows to detect a situation when there are errors accessing RPCs endpoints for some ibc path.
Currently cosmos_ibc_client_expiry metric isn't published in such case. With this PR it will be published with status label equal error.

- chainId: nois-1
url: https://nois-rpc.polkachu.com:443
- chainId: osmo-test-5
url: https://rpc.osmotest5.osmosis.zone:443
- chainId: osmosis-1
url: https://osmosis-rpc.stakely.io:443
- chainId: sandbox-01
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added with 05d53e4

Copy link
Contributor

@shahbazn shahbazn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kayano kayano merged commit f0dffc0 into main Sep 26, 2023
@kayano kayano deleted the tn/status-label branch September 26, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants