fix: Add --color flag to Trivy CLI #8250
Open
+32
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes aquasecurity#1566 Add a new CLI option `--color` to enable or disable color output in Trivy. * **Flag Definition:** - Add `ColorFlag` in `pkg/flag/report_flags.go` to handle color settings. - Update `ReportFlagGroup` to include the new `ColorFlag`. * **Command Integration:** - Update `NewApp` function in `pkg/commands/app.go` to include the new `ColorFlag`. - Modify `cmd/trivy/main.go` to initialize the color settings based on the `--color` flag. * **Documentation:** - Update `docs/docs/references/configuration/cli/trivy_image.md` to include the new `--color` option. - Update `docs/docs/references/configuration/cli/trivy_filesystem.md` to include the new `--color` option. - Update `docs/docs/references/configuration/cli/trivy_config.md` to include the new `--color` option. - Update `docs/docs/references/configuration/cli/trivy.md` to include the new `--color` option. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/aquasecurity/trivy/issues/1566?shareId=XXXX-XXXX-XXXX-XXXX).
|
|
anupamme
changed the title
|
As commented here, |
nitrocode
reviewed
Feb 13, 2025
| } | ||
|
|
||
| func NewReportFlagGroup() *ReportFlagGroup { | ||
| return &ReportFlagGroup{ | ||
| Format: FormatFlag.Clone(), | ||
| ReportFormat: ReportFormatFlag.Clone(), | ||
| Template: TemplateFlag.Clone(), | ||
| Template: TemplateFlag.Clone(), |
nitrocode
reviewed
Feb 13, 2025
There was a problem hiding this comment.
I don't think this will affect all areas of the code base.
You can see custom packages like chroma which add color and this color flag should also impact these libraries to ensure color either remains or is removed when running the trivy cli
trivy/pkg/iac/scan/highlighting.go
Line 12 in bf64003
See this comment for more information #1091 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1566
Add a new CLI option
--colorto enable or disable color output in Trivy.Flag Definition:
ColorFlaginpkg/flag/report_flags.goto handle color settings.ReportFlagGroupto include the newColorFlag.Command Integration:
NewAppfunction inpkg/commands/app.goto include the newColorFlag.cmd/trivy/main.goto initialize the color settings based on the--colorflag.Documentation:
docs/docs/references/configuration/cli/trivy_image.mdto include the new--coloroption.docs/docs/references/configuration/cli/trivy_filesystem.mdto include the new--coloroption.docs/docs/references/configuration/cli/trivy_config.mdto include the new--coloroption.docs/docs/references/configuration/cli/trivy.mdto include the new--coloroption.For more details, open the Copilot Workspace session.