Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIP-50][Discussion] Change Commission rates in delegation pools #249

Closed
junkil-park opened this issue Sep 28, 2023 · 2 comments
Closed

Comments

@junkil-park
Copy link
Contributor

junkil-park commented Sep 28, 2023

AIP Discussion

Currently, the commission rate is set by the pool owner at initiation of the pool. We propose allowing the pool owner to change the commission rate after delegation pool creation.

Read more about it here: https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-50.md

@junkil-park junkil-park changed the title [AIP-X][Discussion] Change Commission rates in delegation pools [AIP-50][Discussion] Change Commission rates in delegation pools Sep 28, 2023
@thepomeranian thepomeranian added this to the aptos-node-v1.8 milestone Oct 5, 2023
@alinush
Copy link
Contributor

alinush commented Oct 12, 2023

This seems worrisome for users: they stake and now they have to be vigilant the pool doesn't increase its commission.

For decreases, its fine: users make more.

For increases, why can't the pool owner start a new pool with a new commission instead?

@michelle-aptos
Copy link
Collaborator

This seems worrisome for users: they stake and now they have to be vigilant the pool doesn't increase its commission.

For decreases, its fine: users make more.

For increases, why can't the pool owner start a new pool with a new commission instead?

they need 1M APT so it would be difficult to start a new pool. to mitigate the risk for users, there is a cap on the commission change per lockup cycle and it also must be made 7 days prior to the end of the lockup, taking effect in the next cycle. there should be a notification of the commission change so that way users can unstake before the commission changes.

@thepomeranian thepomeranian removed this from the aptos-node-v1.8 milestone Oct 26, 2023
@thepomeranian thepomeranian added this to the aptos-node-v1.9 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants