ensure no-ui-slider has start value

aptible · Jan 16, 2015 · 8e25571 · 8e25571
1 parent f8a9de9
commit 8e25571
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/app/components/no-ui-slider/component.js b/app/components/no-ui-slider/component.js
@@ -10,6 +10,11 @@ export default Ember.Component.extend({
   rangeMax: 0,
   step: null,
 
+  validateProperties: function(){
+    Ember.assert('no-ui-slider must have a value for `start`',
+                 !Ember.isBlank(this.get('start')));
+  }.on('init'),
+
   initializeSlider: function(){
     var options = {
       start: [this.get('start')],

diff --git a/tests/acceptance/apps-show-test.js b/tests/acceptance/apps-show-test.js
@@ -25,17 +25,7 @@ test('visiting /apps/my-app-id shows basic app info', function() {
     return this.success({
       id: appId,
       handle: 'my-app',
-      _links: { services: { href: '/apps/' + appId + '/services' } }
-    });
-  });
-
-  stubRequest('get', '/apps/' + appId + '/services', function(request){
-    return this.success({
-      _embedded: {
-        services: [{
-          id: serviceId
-        }]
-      }
+      _embedded: { services: [] }
     });
   });
 

diff --git a/tests/helpers/aptible-helpers.js b/tests/helpers/aptible-helpers.js
@@ -171,7 +171,8 @@ Ember.Test.registerHelper('stubStacks', function(app, options){
             _embedded: {
               services: [{
                 id: '1',
-                handle: 'the-service'
+                handle: 'the-service',
+                container_count: 1
               }]
             }
           }, {
@@ -180,7 +181,8 @@ Ember.Test.registerHelper('stubStacks', function(app, options){
             _embedded: {
               services: [{
                 id: '2',
-                handle: 'the-service-2'
+                handle: 'the-service-2',
+                container_count: 1
               }]
             }
           }]