Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] App crashes when switching between google sheets action and another normal api action #4204

Closed
nidhi-nair opened this issue Apr 29, 2021 · 2 comments · Fixed by #4282
Closed
Assignees
Labels
Bug Something isn't working Core Query Execution Issues related to the execution of all queries High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Query & JS Pod Issues related to the query & JS Pod Release Verified When issue is retested post its fixed

Comments

@nidhi-nair
Copy link
Contributor

Description

When trying to navigate to the debugger from the toast message that pops up on action execution failure, the debugger does not open. Trying to navigate back to the canvas also crashes the app. Captured this in a 2 minute long video for all scenarios I could think of.

Steps to reproduce the behaviour:

  1. Create any error for page load (cyclical dependency might be easy to repro)
  2. Navigate to any of the datasources/query editors/API pane/etc and refresh page to trigger the error
  3. Try to click on debug on the toast message.
  4. Navigation fails
  5. Exit the current pane, expecting to go back to the canvas. Here the app will crash.
Screen.Recording.2021-04-29.at.11.30.34.AM.mov

Important Details

  • Version: [Cloud / Self-Hosted vx.x]
  • OS: [e.g.MacOSX]
  • Browser [e.g. chrome, safari]
@nidhi-nair nidhi-nair added Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Release Debugger Product Issues related to the debugger Needs Triaging Needs attention from maintainers to triage labels Apr 29, 2021
@Nikhil-Nandagopal
Copy link
Contributor

@nidhi-nair thanks for the great catch!

@akash-codemonk
Copy link
Contributor

akash-codemonk commented Apr 29, 2021

Will create a separate issue #4207 for the navigation not happening from toast.

The crash seems to be an issue with the datasource url editor(codeeditor) in the api pane while switching from a google sheets action to a normal api action.

Steps

  1. Create a new application
  2. Create a google sheet api action
  3. Create a normal api action
  4. Switch between the two actions it crashes

Loom recording

Console error
error-crash

Another reason for the crash could be #4209

@akash-codemonk akash-codemonk added Core Query Execution Issues related to the execution of all queries API pane and removed Debugger Product Issues related to the debugger labels Apr 29, 2021
@akash-codemonk akash-codemonk changed the title [Bug] App crashes if you try to debug from almost everywhere except the canvas [Bug] App crashes when switching between google sheets action and another normal api action Apr 29, 2021
@ApekshaBhosale ApekshaBhosale self-assigned this May 3, 2021
@close-label close-label bot added the QA Needs QA attention label May 4, 2021
@prapullac prapullac added Verified When issue is retested post its fixed and removed QA Needs QA attention labels May 6, 2021
@github-actions github-actions bot added the Query & JS Pod Issues related to the query & JS Pod label Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Core Query Execution Issues related to the execution of all queries High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Query & JS Pod Issues related to the query & JS Pod Release Verified When issue is retested post its fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants