Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a common container component with styles #37609

Closed
Tracked by #37342
ankitakinger opened this issue Nov 21, 2024 · 0 comments · Fixed by #38321
Closed
Tracked by #37342

Create a common container component with styles #37609

ankitakinger opened this issue Nov 21, 2024 · 0 comments · Fixed by #38321
Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo

Comments

@ankitakinger
Copy link
Contributor

ankitakinger commented Nov 21, 2024 •
edited
Loading

Create a common component with styles that defines the wrapper for the Explorer on the left. It should not have any logic or any UI as children pre-defined. Children should come as props.

We need to remove the ideViewMode checks in styles and get the values for borderRight and width from props.

Component: https://github.com/appsmithorg/appsmith/blob/release/app/client/src/pages/Editor/IDE/EditorPane/Explorer.tsx
@ankitakinger ankitakinger mentioned this issue Nov 21, 2024
Open
1 task
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Nov 21, 2024
@ankitakinger ankitakinger added IDE Product Issues related to the IDE Product IDE Pod Issues that new developers face while exploring the IDE labels Nov 21, 2024
@hetunandu hetunandu mentioned this issue Dec 23, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Move smaller Entity Explorer components into ADS appsmithorg/appsmith
2 participants
@Nikhil-Nandagopal @ankitakinger