Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Page names from the master branch appear when pasting a URL in Git-connected app, despite viewing a different branch #36537

Open
1 task done
shadabbuchh opened this issue Sep 25, 2024 · 4 comments · Fixed by #37274
Assignees
Labels
App Navigation Issues related to the topbar navigation and configuring it Bug Something isn't working Customer Success Issues that the success team cares about Git Product Issues related to version control product Medium Issues that frustrate users due to poor UX Packages & Git Pod All issues belonging to Packages and Git Production UI Building Product Issues related to the UI Building experience

Comments

@shadabbuchh
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

When pasting a page URL from a Git-connected app, the content of the page is displayed correctly, but the page names shown correspond to the master branch instead of the specific branch being viewed.

Steps To Reproduce

  1. In a git connected app have 2 branche e.g. Master & BranchOne.
  2. In Master create two pages (Page 1 & Page 2) & commit
  3. In Branch One create 3 Pages (FirstPage, SecondPage, ThirdPage) & commit
  4. Copy & paste the URL of ThirdPage from BranchOne.

Expected: The content displayed should be of ThirdPage & also the page names should be of BranchOne.
Actual: Even though the content is displayed correctly, The page names displayed are of Master

Public Sample App

No response

Environment

Production

Severity

High (Blocker to building or releasing)

Issue video log

https://jam.dev/c/dadd3f11-bf38-4cc5-8a89-541dba23b105

Version

Cloud

@shadabbuchh shadabbuchh added Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Production Needs Triaging Needs attention from maintainers to triage Git Product Issues related to version control product App Navigation Issues related to the topbar navigation and configuring it labels Sep 25, 2024
@github-actions github-actions bot added UI Building Product Issues related to the UI Building experience Git Platform Issues related to the git & the app platform labels Sep 25, 2024
@riteshkew riteshkew added Medium Issues that frustrate users due to poor UX and removed High This issue blocks a user from building or impacts a lot of users labels Sep 25, 2024
@riteshkew
Copy link
Contributor

riteshkew commented Sep 25, 2024

URL navigation defaulting to "master" when no query param for branch is provided

@riteshkew riteshkew added Critical This issue needs immediate attention. Drop everything else Customer Success Issues that the success team cares about labels Oct 16, 2024
Copy link

This critical issue has not seen activity for a while. It will be closed in 7 days unless further activity is detected or the Critical tag is removed.

@github-actions github-actions bot added the Stale label Oct 23, 2024
Copy link

github-actions bot commented Nov 2, 2024

This issue has been closed because of inactivity.

@github-actions github-actions bot closed this as completed Nov 2, 2024
@nidhi-nair nidhi-nair removed the Stale label Nov 4, 2024
@nidhi-nair nidhi-nair reopened this Nov 4, 2024
@nidhi-nair nidhi-nair removed Critical This issue needs immediate attention. Drop everything else Needs Triaging Needs attention from maintainers to triage labels Nov 4, 2024
@shadabbuchh
Copy link
Contributor Author

After discussion with @sondermanish this issue is still present on prod & his fix PR was not meant to fix this particular issue. Hence reopening it.

@shadabbuchh shadabbuchh reopened this Nov 13, 2024
@riteshkew riteshkew added the Packages & Git Pod All issues belonging to Packages and Git label Nov 18, 2024
@github-actions github-actions bot removed the Git Platform Issues related to the git & the app platform label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Navigation Issues related to the topbar navigation and configuring it Bug Something isn't working Customer Success Issues that the success team cares about Git Product Issues related to version control product Medium Issues that frustrate users due to poor UX Packages & Git Pod All issues belonging to Packages and Git Production UI Building Product Issues related to the UI Building experience
Projects
None yet
3 participants