Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Action execution should only trigger after all entities are saved #34995

Closed
1 task done
ame-appsmith opened this issue Jul 17, 2024 · 2 comments
Closed
1 task done
Assignees
Labels
Bug Something isn't working Core Query Execution Issues related to the execution of all queries High This issue blocks a user from building or impacts a lot of users Integrations Product Issues related to a specific integration Javascript Product Issues related to users writing javascript in appsmith JS Objects Issues related to JS Objects Query & JS Pod Issues related to the query & JS Pod

Comments

@ame-appsmith
Copy link

ame-appsmith commented Jul 17, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Summary

Body + update action one set has to finish before the second set of body + update action occurs.

Context: The user is getting the message Appsmith Server is taking too Long to Respond when editing JS Objects or working in the Page editor with widgets. It happens when saving or just loading queries.
The root cause is that the JS Object did not finish saving before the user tried to execute another action. To work around this problem, when the saving of a particular JS Object is still in progress, users need to wait until it finishes before moving to another page/entity or making new changes in the UI.

More information in this ticket and Slack thread.

Why should this be worked on?

We need to improve the user experience if the JS Object that was edited is not saved yet when a new action is done.

@ame-appsmith ame-appsmith added Enhancement New feature or request UI Performance Issues related to UI performance labels Jul 17, 2024
@github-actions github-actions bot added the UI Building Product Issues related to the UI Building experience label Jul 17, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal removed UI Building Product Issues related to the UI Building experience UI Performance Issues related to UI performance labels Jul 17, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal changed the title [Feature]: Make Updates Call in Sync Manner [Bug]: Action execution should only trigger after all entities are saved Jul 17, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Bug Something isn't working Medium Issues that frustrate users due to poor UX and removed Enhancement New feature or request labels Jul 17, 2024
@rishabhrathod01 rishabhrathod01 added JS Objects Issues related to JS Objects Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. labels Jul 22, 2024
@github-actions github-actions bot added Javascript Product Issues related to users writing javascript in appsmith Integrations Product Issues related to a specific integration labels Jul 22, 2024
@nghialm269
Copy link

Hi, I've been seeing the same message (Appsmith Server is taking too Long to Respond) a lot recently while working on my app.

Whenever I edited a jsobject file (~300 lines), a Saving spinner showed up at the top, and the message appeared after a while (I guess the save request timed out after 20s or so).

After too many timeouts like that, the code editor refreshed itself (it scrolls to the top) and my changes were lost.

I've tried to split the jsobject file into smaller files as advised, it helps a bit but not too much.

For some more context, when I tried to create a new jsobject in the same app and add a new line, it took ~3s to save. This app has 2 jsobject files with 300 lines, 1 with 100 lines, and 4 with 50 lines.

When I tried the same with a smaller app (1 file with 15 lines), it took ~300ms to save.

@sneha122 sneha122 added the High This issue blocks a user from building or impacts a lot of users label Aug 5, 2024
@sneha122 sneha122 removed the Medium Issues that frustrate users due to poor UX label Aug 5, 2024
@github-actions github-actions bot added the Query & JS Pod Issues related to the query & JS Pod label Aug 5, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the IDE Pod Issues that new developers face while exploring the IDE label Aug 5, 2024
@github-actions github-actions bot removed the IDE Pod Issues that new developers face while exploring the IDE label Aug 5, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Artifact Platform Product Issues related to the application platform and removed IDE Pod labels Aug 5, 2024
@github-actions github-actions bot added the Git Platform Issues related to the git & the app platform label Aug 6, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Core Query Execution Issues related to the execution of all queries and removed IDE Product Issues related to the IDE Product IDE Pod Issues that new developers face while exploring the IDE Save Entity Query & JS Pod Issues related to the query & JS Pod Integrations Product Issues related to a specific integration Git Platform Issues related to the git & the app platform Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Artifact Platform Product Issues related to the application platform labels Aug 6, 2024
@github-actions github-actions bot added the Integrations Product Issues related to a specific integration label Aug 6, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Query & JS Pod Issues related to the query & JS Pod label Aug 6, 2024
@rishabhrathod01
Copy link
Contributor

This issue title and description got mixed up of multiple different issues, i have create separate issues for each problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Core Query Execution Issues related to the execution of all queries High This issue blocks a user from building or impacts a lot of users Integrations Product Issues related to a specific integration Javascript Product Issues related to users writing javascript in appsmith JS Objects Issues related to JS Objects Query & JS Pod Issues related to the query & JS Pod
Projects
None yet
Development

No branches or pull requests

10 participants