Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: User should be able to configure default git branch at the app level #24879

Closed
1 task done
pranavkanade opened this issue Jun 27, 2023 · 7 comments
Closed
1 task done
Assignees
Labels
Enhancement New feature or request Git Platform Issues related to the git & the app platform Git Product Issues related to version control product

Comments

@pranavkanade
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Summary

A user wants to use git-sync to facilitate multiple environments. We only support changing the default branch from git-repo and then syncing it back in Appsmith. Although, the user needs to be able to change the default branch at the app level regardless of the default branch set at the repository level.

Why should this be worked on?

This will allow the user to have different applications - prod, qa, dev with separate default branches.

@pranavkanade pranavkanade added Enhancement New feature or request Git Product Issues related to version control product labels Jun 27, 2023
@github-actions github-actions bot added the Git Platform Issues related to the git & the app platform label Jun 27, 2023
@pranavkanade
Copy link
Contributor Author

Related article - https://community.appsmith.com/solution/how-change-default-branch-appsmith-app

@infinitetrooper
Copy link
Contributor

This is being worked on in the epic #26530

@rhuanbarreto
Copy link

This is very much important for us! One use case:

We normally merge all things to the main branch. But sometimes we need to do a hotfix on it without changing the history of the main branch. So we create a hotfix branch and we want this branch to be the one that the user launches when they press the "Launch" Button.

This feature of changing the default branch would be very important so we can point the users to the right branch when using the application.

@infinitetrooper
Copy link
Contributor

This was released on Appsmith Enterprise v1.9.46

@rhuanbarreto
Copy link

@Nikhil-Nandagopal any reason this didn't come for business edition as well? We discussed this recently and I was ready to give it a try.

@Nikhil-Nandagopal
Copy link
Contributor

@rhuanbarreto I spoke to @infinitetrooper and this feature was planned as part of our epic to support multi-instance deployments for enterprises. I believe your use case was

  • Take the default branch set in the git repository (main instead of master)
  • Deploy a hotfix branch of an application

I believe point #1 should be working once you set it in your repo settings.
For point #2:
I think deploying a hotfix branch isn't the purpose of this feature because the URL will change and so users will end up getting confused if they have the application URL bookmarked or they had the application open already.

Is there a reason your hotfix isn't going to the master branch? Because that should solve this problem

@rhuanbarreto
Copy link

The branching problem is partially on us as well. Because we use also 3 separate appsmith instances in order to deploy applications, which generates a commit lag between the dev/test/prod instances that are all connected to the main branch but not synchronized. So this feature would cover our current usage as well.

Totally understand the bookmark use case but this use case could be solved by removing the branch parameter on the main branch. Then the bookmark would be affected by the change.

For now we changed to use 3 different branches for each environment as a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Git Platform Issues related to the git & the app platform Git Product Issues related to version control product
Projects
None yet
Development

No branches or pull requests

5 participants