From 946e687af6876497c6d25a4c53e2eda230fe21d8 Mon Sep 17 00:00:00 2001 From: Diljit Date: Sun, 2 Feb 2025 15:18:03 +0530 Subject: [PATCH] chore: add logs in computeConsolidatedAPIResponseEtag fn (#38948) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description Add logs in computeConsolidatedAPIResponseEtag fn Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### :mag: Cypress test results > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: > Commit: 159925bd6a5e9e18aa4a2c235353020b9f09da12 > Cypress dashboard. > Tags: `@tag.All` > Spec: >
Sat, 01 Feb 2025 17:24:22 UTC ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No --- .../server/services/ce/ConsolidatedAPIServiceCEImpl.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ConsolidatedAPIServiceCEImpl.java b/app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ConsolidatedAPIServiceCEImpl.java index 0e8c54d51156..db9fa98db03c 100644 --- a/app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ConsolidatedAPIServiceCEImpl.java +++ b/app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ConsolidatedAPIServiceCEImpl.java @@ -648,6 +648,10 @@ private boolean isPossibleToCreateQueryWithoutDatasource(Plugin plugin) { @NotNull public String computeConsolidatedAPIResponseEtag( ConsolidatedAPIResponseDTO consolidatedAPIResponseDTO, String defaultPageId, String applicationId) { if (isBlank(defaultPageId) && isBlank(applicationId)) { + log.debug( + "Skipping etag computation: Both defaultPageId '{}', and applicationId '{}' are blank", + defaultPageId, + applicationId); return ""; } @@ -664,6 +668,10 @@ private boolean isPossibleToCreateQueryWithoutDatasource(Plugin plugin) { : null; if (lastDeployedAt == null) { + log.debug( + "Skipping etag computation: lastDeployedAt is null for applicationId '{}', pageId '{}'", + applicationId, + defaultPageId); return ""; }