Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support creating OpenShift VCS labels #52

Closed
seabaylea opened this issue Mar 17, 2020 · 1 comment
Closed

Support creating OpenShift VCS labels #52

seabaylea opened this issue Mar 17, 2020 · 1 comment
Assignees

Comments

@seabaylea
Copy link

Feature Request

Is your feature request related to a problem?

There's a standard set of labels OpenContainers labels/annotations which allow you to specify information such as where the source repository is and what revision is used.

By default, microservices created by the Appsody project set the following labels:

    image.opencontainers.org/created: "2020-03-17T11:48:58Z"
    image.opencontainers.org/documentation: https://github.com/seabaylea/backend
    image.opencontainers.org/revision: 8be7def88e73b0e311b8517bd0a960bc03f5282d-modified
    image.opencontainers.org/source: https://github.com/seabaylea/backend/tree/master
    image.opencontainers.org/url: https://github.com/seabaylea/backend

However, OpenShift uses its own labels to store version control information.

Describe the solution you'd like

Where the application provides open container label, but not the corresponding OpenShift annotations, the Runtime Component Operator could create the OpenShift equivalents (when deploying to OpenShift).

The list of OpenShift labels and annotations are here:
https://github.com/gorkem/app-labels/blob/master/labels-annotation-for-openshift.adoc

The relevant two in this scenario are:

app.openshift.io/vcs-uri
app.openshift.io/vcs-ref
@leochr
Copy link
Member

leochr commented Mar 23, 2020

Resolved by PR #54

@leochr leochr closed this as completed Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants