synthesized comparable for enums #25696

tayloraswift · 2019-06-23T22:24:03Z

WIP: Implementation for Synthesized Comparable conformance for simple enum types.

DougGregor · 2019-09-11T00:24:34Z

@swift-ci please smoke test

tayloraswift · 2019-09-11T00:55:29Z

note: i had fixed the merge conflicts to the point where it’s compiling again but it crashes at run time, so the update isn’t really ready yet

tayloraswift · 2019-09-19T02:33:27Z

@DougGregor hi, i’ve pushed changes that fixed the crasher, added support for enums with associated values, and updated the tests. i think it’s in a working state right now and it was able to pass the entire test suite, including new tests.

DougGregor · 2019-09-19T22:24:58Z

@swift-ci please smoke test

DougGregor · 2019-09-19T22:25:04Z

@swift-ci please test source compatibility

DougGregor · 2019-09-19T22:29:24Z

@Kelvin13 looks like we changed something on master that broke this:

/Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/lib/Sema/DerivedConformanceComparable.cpp:375:21: error: no member named 'setGenericEnvironment' in 'swift::FuncDecl'
15:28:09     comparableDecl->setGenericEnvironment(genericEnv);
15:28:09     ~~~~~~~~~~~~~~  ^
15:28:09 1 error generated.

tayloraswift · 2019-09-20T00:37:07Z

can we try this again @DougGregor

DougGregor · 2019-09-20T17:01:46Z

@swift-ci please smoke test

DougGregor · 2019-09-20T21:53:35Z

@swift-ci please test source compatibility

harlanhaskins · 2019-11-21T01:14:35Z

@Kelvin13 Can you fix the conflicts? I'll poke CI again.

harlanhaskins · 2019-11-21T18:49:36Z

Thanks, @Kelvin13!

@swift-ci please smoke test

harlanhaskins · 2019-11-21T18:49:43Z

@swift-ci please test source compatibility

harlanhaskins · 2019-11-21T23:05:08Z

@swift-ci please smoke test Linux

harlanhaskins · 2019-11-21T23:05:13Z

@swift-ci please test source compatibility

harlanhaskins · 2019-11-21T23:05:21Z

Test failures were unrelated.

tayloraswift · 2019-11-22T00:48:52Z

new version should be passing the test

theblixguy · 2019-11-22T00:53:46Z

@swift-ci please smoke test

theblixguy · 2019-11-22T00:53:58Z

@swift-ci please test source compatibility

theblixguy · 2019-11-22T09:20:27Z

@swift-ci please test source compatibility debug

tayloraswift · 2019-12-02T19:45:36Z

this is all green on the checks, can we merge?

harlanhaskins · 2019-12-02T20:15:32Z

@DougGregor good to merge?

CodaFi · 2020-01-31T05:53:19Z

The sizes can probably just be rationalized in one go in a follow-up.

tayloraswift · 2020-02-02T20:53:13Z

Alright, the AST synthesis looks fine for now.

Please also update Interpreter/synthesized_extension_conformances.swift and add a test to test/Sema/enum_conformance_synthesis.swift that involves an extension.

done

harlanhaskins · 2020-02-02T21:11:37Z

@swift-ci please test

harlanhaskins · 2020-02-02T21:11:54Z

@swift-ci please test source compatibility

swift-ci · 2020-02-02T21:14:06Z

Build failed
Swift Test Linux Platform
Git Sha - d71b3df

swift-ci · 2020-02-02T21:15:21Z

Build failed
Swift Test OS X Platform
Git Sha - d71b3df

tayloraswift · 2020-02-02T22:19:30Z

the error seems real, but it’s not happening when I run the build on my machine? any idea what’s going on? this is the invocation i’m using:

swift/utils/build-script --release-debuginfo -t

benrimmington · 2020-02-03T00:10:54Z

the error seems real, but it’s not happening when I run the build on my machine?

Are you testing locally on Linux? It // REQUIRES: objc_interop for some reason.

tayloraswift · 2020-02-03T01:43:30Z

@benrimmington yes

CodaFi · 2020-02-03T01:52:50Z

Try a release-asserts build.

tayloraswift · 2020-02-03T21:36:56Z

@benrimmington that doesn’t work, it fails to import Foundation

swift/test/Interpreter/synthesized_extension_conformances.swift:8:8: error: no such module 'Foundation'
import Foundation

adding --assert doesn’t seem to do anything different either

tayloraswift · 2020-02-03T21:37:19Z

It looks like the test failure on macOS can be fixed with:
-struct SInt: Codable, Equatable, Hashable {
+struct SInt: Codable, Equatable, Hashable, Comparable {
You could also try removing the // REQUIRES: objc_interop and see if the tests pass on Linux.

Comparable can’t be synthesized on structs, only enums

theblixguy · 2020-02-03T21:57:39Z

Comparable can’t be synthesized on structs, only enums

That is true, but that's not what the error is about. The error appears because SInt doesn't conform to Comparable and the reason why is because you added an extension to EGeneric which requires its generic parameter to be Comparable:

extension EGeneric: Comparable where T: Comparable {}

In your test function, you're using EGeneric<SInt> but the compiler is unable to synthesise Comparable conformance for EGeneric because SInt doesn't conform to Comparable.

tayloraswift · 2020-02-04T23:56:15Z

i couldn’t get Foundation to build (part of the compiler needs libssl1.0-dev and another part seems to need libcurl4-openssl-dev and they conflict with each other)

could someone trigger the ci?

harlanhaskins · 2020-02-05T00:13:19Z

@Kelvin13 Can you go ahead and resolve these new conflicts? I'll kick CI after

harlanhaskins · 2020-02-05T04:39:10Z

@swift-ci please test

swift-ci · 2020-02-05T04:40:02Z

Build failed
Swift Test OS X Platform
Git Sha - 178b0ff

swift-ci · 2020-02-05T04:41:41Z

Build failed
Swift Test Linux Platform
Git Sha - 178b0ff

harlanhaskins · 2020-02-05T07:19:03Z

@swift-ci please test source compatibility

tayloraswift · 2020-02-05T21:11:36Z

@CodaFi ping

CodaFi

CodaFi · 2020-02-07T05:38:34Z

⛵️

theblixguy · 2020-02-09T23:00:53Z

@Kelvin13 do you mind adding this to the changelog?

tayloraswift · 2020-02-12T05:11:34Z

@theblixguy #29782

comparable enums

210ec69

tayloraswift added 3 commits September 18, 2019 18:46

fix compiler crash

08aa01f

support associated values

c915fb6

update tests

e13beb1

tayloraswift added 2 commits September 19, 2019 19:32

Merge remote-tracking branch 'upstream/master' into comparable-enums

87a6ba2

fix setGenericSignature

37edea6

theblixguy added the swift evolution approved Flag → feature: A feature that was approved through the Swift evolution process label Oct 25, 2019

fix conflicts

e4dc295

fix build failures

25e4cfc

add tests

178b0ff

This comment has been minimized.

Sign in to view

SInt comparable

206e3b1

Merge branch 'master' into comparable-enums

19a8759

CodaFi approved these changes Feb 7, 2020

View reviewed changes

CodaFi merged commit 1ed846d into swiftlang:master Feb 7, 2020

synthesized comparable for enums #25696

synthesized comparable for enums #25696

Conversation

tayloraswift commented Jun 23, 2019 • edited Loading

DougGregor commented Sep 11, 2019

tayloraswift commented Sep 11, 2019 • edited Loading

tayloraswift commented Sep 19, 2019 • edited Loading

DougGregor commented Sep 19, 2019

DougGregor commented Sep 19, 2019

DougGregor commented Sep 19, 2019

tayloraswift commented Sep 20, 2019 • edited Loading

DougGregor commented Sep 20, 2019

DougGregor commented Sep 20, 2019

harlanhaskins commented Nov 21, 2019

harlanhaskins commented Nov 21, 2019

harlanhaskins commented Nov 21, 2019

harlanhaskins commented Nov 21, 2019

harlanhaskins commented Nov 21, 2019

harlanhaskins commented Nov 21, 2019

tayloraswift commented Nov 22, 2019

theblixguy commented Nov 22, 2019

theblixguy commented Nov 22, 2019

theblixguy commented Nov 22, 2019

tayloraswift commented Dec 2, 2019

harlanhaskins commented Dec 2, 2019

CodaFi commented Jan 31, 2020

tayloraswift commented Feb 2, 2020

harlanhaskins commented Feb 2, 2020

harlanhaskins commented Feb 2, 2020

swift-ci commented Feb 2, 2020

swift-ci commented Feb 2, 2020

tayloraswift commented Feb 2, 2020

benrimmington commented Feb 3, 2020

tayloraswift commented Feb 3, 2020

CodaFi commented Feb 3, 2020 • edited Loading

This comment has been minimized.

tayloraswift commented Feb 3, 2020

tayloraswift commented Feb 3, 2020

theblixguy commented Feb 3, 2020 • edited Loading

This comment has been minimized.

tayloraswift commented Feb 4, 2020

harlanhaskins commented Feb 5, 2020

harlanhaskins commented Feb 5, 2020

swift-ci commented Feb 5, 2020

swift-ci commented Feb 5, 2020

harlanhaskins commented Feb 5, 2020

tayloraswift commented Feb 5, 2020

CodaFi left a comment

Choose a reason for hiding this comment

CodaFi commented Feb 7, 2020

theblixguy commented Feb 9, 2020

tayloraswift commented Feb 12, 2020

tayloraswift commented Jun 23, 2019 •

edited

Loading

tayloraswift commented Sep 11, 2019 •

edited

Loading

tayloraswift commented Sep 19, 2019 •

edited

Loading

tayloraswift commented Sep 20, 2019 •

edited

Loading

CodaFi commented Feb 3, 2020 •

edited

Loading

theblixguy commented Feb 3, 2020 •

edited

Loading