[stdlib] Make unsafe array initializer public #23134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natecook1000
added
the
swift evolution pending discussion
|
@swift-ci Please smoke test |
|
@airspeedswift I was expecting this to fail the stable ABI test, since it’s adding new API — does that only track changes and deletions? |
|
@swift-ci Please smoke test Linux platform |
|
@swift-ci Please smoke test Linux platform |
jrose-apple
reviewed
Mar 19, 2019
|
The corresponding evolution proposal has been accepted. |
tkremenek
added
swift evolution approved
|
@swift-ci clean test |
The original underscored version of this initializer remains, with a deprecation notice. Also add the initializer to ContiguousArray.
This strategy lets us avoid availability constraints on the new public methods, since the original underscored version is part of the permanent ABI.
natecook1000
force-pushed
the
nc_unsafeUninitializedCapacity
branch
from
4f1aa93 to
e37f7d5
Compare
|
@swift-ci Please test |
jrose-apple
reviewed
Mar 21, 2019
|
@swift-ci Please test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Catfish-Man
approved these changes
Mar 21, 2019
|
@swift-ci Please smoke test |
natecook1000
added a commit
to natecook1000/swift
that referenced
this pull request
Mar 23, 2019
[stdlib] Make unsafe array initializer public This implements SE-0245. The public versions of this initializer call into the existing, underscored version, which avoids the need for availability constraints.
AnthonyLatsis
removed
the
swift evolution approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation for the re-pitch of SE-0223.
The original underscored version of this initializer remains, with a deprecation notice. Also adds the initializer to
ContiguousArray. Still to do:ContiguousArrayand the non-underscoredArrayversionResolves #45677.