Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SwiftProtobuf to the Swift source compatibility suite #486

Closed
allevato opened this issue Apr 24, 2017 · 3 comments
Closed

Add SwiftProtobuf to the Swift source compatibility suite #486

allevato opened this issue Apr 24, 2017 · 3 comments

Comments

@allevato
Copy link
Collaborator

The Swift team has created a manifest of real-world Swift projects that get regularly built against development snapshots to verify source compatibility. We should add this project.

https://swift.org/source-compatibility/#adding-projects

@thomasvl
Copy link
Collaborator

Is this still worth doing?

Swift Unwrapped: 39: Source Compatibility Suite Woes talked about how project get disabled in the suite without being informed, and other issues. So I'm not sure if it is/isn't worth adding.

I'm guessing #904 could have caused this project to have gotten disabled at some point.

@allevato
Copy link
Collaborator Author

Or would it have revealed a legitimate regression in the exhaustiveness checker? 🤔

@thomasvl
Copy link
Collaborator

I'm going to close this, since we haven't done it and from the linked Swift Unwrapped it isn't clear if it is worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants