Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update to Swift 6 CI #122

Merged
merged 3 commits into from
Oct 16, 2024
Merged

[CI] Update to Swift 6 CI #122

merged 3 commits into from
Oct 16, 2024

Conversation

FranzBusch
Copy link
Member

Motivation

We just updated our CI matrix in NIO to only support 5.9, 5.10 and 6.

Modification

This PR updates the trigger files in this repo. Since this repo was always 5.9+ this is easy.

Result

Up to date CI

@czechboy0
Copy link
Contributor

@FranzBusch

[Invalid workflow file: .github/workflows/pull_request.yml#L10](https://github.com/apple/swift-openapi-runtime/actions/runs/11345355766/workflow)
error parsing called workflow
".github/workflows/pull_request.yml"
-> "apple/swift-nio/.github/workflows/soundness.yml@main"
: failed to fetch workflow: workflow was not found.

@@ -9,22 +9,15 @@ jobs:
name: Soundness
uses: apple/swift-nio/.github/workflows/soundness.yml@main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be switched to the reusable one?

@@ -9,9 +9,9 @@ jobs:
name: Unit tests
uses: apple/swift-nio/.github/workflows/unit_tests.yml@main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the other one but this one is correct

# Motivation

We just updated our CI matrix in NIO to only support 5.9, 5.10 and 6.

# Modification

This PR updates the trigger files in this repo. Since this repo was always 5.9+ this is easy.

# Result

Up to date CI
@FranzBusch
Copy link
Member Author

@czechboy0 @simonjbeaumont the documentation pipeline seems to be failing since switching over to the reusable repo updated the toolchain for that workflow from 5.10 to 6.0. It looks like there are some new warnings now that need to be fixed. Could you help me with that?

@czechboy0
Copy link
Contributor

@czechboy0 @simonjbeaumont the documentation pipeline seems to be failing since switching over to the reusable repo updated the toolchain for that workflow from 5.10 to 6.0. It looks like there are some new warnings now that need to be fixed. Could you help me with that?

Yes let me open a separate PR making those fixes first.

@czechboy0 czechboy0 mentioned this pull request Oct 16, 2024
@czechboy0
Copy link
Contributor

@FranzBusch #123

@czechboy0
Copy link
Contributor

@FranzBusch Actually, we have a chicken-and-egg problem, you need to bring this tiny diff into your PR instead, I can't merge mine with green CI anyway: #123

@FranzBusch FranzBusch requested a review from czechboy0 October 16, 2024 08:37
@FranzBusch
Copy link
Member Author

@czechboy0 Thanks for that. I slightly tweaked your commit to also avoid the Return: on the closure since that documents the wrong thing. I am wondering if that should actually be allowed.

@FranzBusch FranzBusch enabled auto-merge (squash) October 16, 2024 08:41
@czechboy0
Copy link
Contributor

@FranzBusch So the YAML linter still fails: PR / Soundness / YAML lint check (pull_request)

@FranzBusch
Copy link
Member Author

@czechboy0 fixed!

@czechboy0
Copy link
Contributor

@czechboy0 fixed!

I still see it as failing 😬

@FranzBusch
Copy link
Member Author

@czechboy0 Finally it's all green. Please do me the honours!

@czechboy0 czechboy0 disabled auto-merge October 16, 2024 13:18
@czechboy0 czechboy0 merged commit a79c21c into main Oct 16, 2024
20 checks passed
@czechboy0 czechboy0 deleted the fb-gha-6.0 branch October 16, 2024 13:18
@czechboy0 czechboy0 added the semver/none No version bump required. label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants