ci: Migrate to GitHub Actions and reusable workflows, part one #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjbeaumont
force-pushed
the
sb/github-actions-migration
branch
from
4769e3e to
0c56144
Compare
simonjbeaumont
changed the title
|
lgtm, could you update CONTRIBUTING.md before I approve this? Or is that coming in the cleanup PR? |
Thanks. This is coming with the final cutover since, until it's the one we use in CI, it's not the one folks should run locally :) |
simonjbeaumont
added a commit
that referenced
this pull request
Oct 2, 2024
### Motivation Following #116 we can now cut over to the soundness checks from the GithHub Actions CI and short-circuit the old CI checks. ### Modifications - Remove most scripts used by old CI - Short-circuit API checking script - Short-circuit the docker CI - Enable soundness tests in GitHub Actions workflow - Ignore docker/* for license check - Remove DocC plugin from package manifest - Update CONTRIBUTING.md with instructions for local run ### Result GitHub Actions CI is the one that we care about. We can then update the branch rules, disable the old webhook, and, finally, remove the vestigial stuff.
simonjbeaumont
added a commit
that referenced
this pull request
Oct 2, 2024
…al) (#118) ### Motivation Following on from #116 and #117, we have now disabled the webhook that was driving the old CI and updated the branch protection rules to require the new GitHub Actions based CI checks. We can now delete the final shims that were keeping the old CI green, since it is no longer running and complete the migration. ### Modifications - Delete all Docker bits and scripts used by old CI. ### Result Migration complete. ### Test Plan We should be seeing _only_ GitHub Actions checks on this PR and they should all be passing (apart from the ones that are explicitly disabled).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following on from the migration in Swift OpenAPI Generator, we need to migrate this repo to GitHub Actions based CI and the reusable workflows that are currently in the NIO repo.
Modifications
In order to bootstrap the migration, we need to merge the workflows in, otherwise we won't get any PR feedback on them while we get them ready. As a practical matter, they are all passing locally (verified) by
actbut it would be nice to stage these in so we can keep a green CI while we migrate and decommission the old CI.So this disables the soundness checks for now, so we can then use a follow up PR to do the cut over with testing in the PR.
Result
Old CI still working, new CI should start running in some capacity.