feat: support top-level await in modules

I thought this was turned on logn ago. But I forgot a flag in the parser as well as declaring the variable that holds the value being pass to await.
getappmap · Feb 15, 2022 · 60ee6e6 · 60ee6e6
1 parent ea17330
commit 60ee6e6
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/components/instrumentation/default/index.mjs b/components/instrumentation/default/index.mjs
@@ -83,6 +83,7 @@ export default (dependencies) => {
                 parseEstree(content, {
                   allowHashBang: true,
                   sourceType: type,
+                  allowAwaitOutsideFunction: type === "module",
                   ecmaVersion: configuration.language.version,
                   locations: true,
                 }),

diff --git a/components/instrumentation/default/visit.mjs b/components/instrumentation/default/visit.mjs
@@ -305,6 +305,12 @@ export default (dependencies) => {
     type: "Program",
     sourceType: type,
     body: [
+      makeVariableDeclaration("let", [
+        makeVariableDeclarator(
+          makeIdentifier(`${runtime}_JUMP`),
+          makeLiteral(null),
+        ),
+      ]),
       makeVariableDeclaration("let", [
         makeVariableDeclarator(
           makeIdentifier(`${runtime}_JUMP_ID`),

diff --git a/components/instrumentation/default/visit.test.mjs b/components/instrumentation/default/visit.test.mjs
@@ -218,7 +218,8 @@ assertEqual(
   ),
   normalize(
     `
-    let $_JUMP_ID = null
+    let $_JUMP = null;
+    let $_JUMP_ID = null;
     try { } catch ($_ERROR) {
       if ($_JUMP_ID !== null) {
         $.recordAfterJump($_JUMP_ID);