Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a new endpoint for element rotation #213

Merged
merged 1 commit into from
Sep 8, 2019
Merged

feat: Add a new endpoint for element rotation #213

merged 1 commit into from
Sep 8, 2019

Conversation

mykola-mokhnach
Copy link

No description provided.

KazuCocoa
KazuCocoa approved these changes Sep 8, 2019
View reviewed changes
Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍 Will we add a mobile command to call this?

@mykola-mokhnach
Copy link
Author

Will we add a mobile command to call this?

Yep, as soon as new WDA version is released

@KazuCocoa
Copy link
Member

👍

@mykola-mokhnach mykola-mokhnach merged commit 9eb3210 into master Sep 8, 2019
@mykola-mokhnach mykola-mokhnach deleted the rotate branch September 8, 2019 19:55
@jlipps
Copy link
Member

jlipps commented Sep 9, 2019

XCUITest lets you rotate elements? that's kind of wacky?

@mykola-mokhnach mykola-mokhnach mentioned this pull request Sep 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mykola-mokhnach @KazuCocoa @jlipps