feat: add disableWindowAnimation caps #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
KazuCocoa
reviewed
Feb 28, 2023
pr4bh4sh
requested review from
KazuCocoa and
mykola-mokhnach
and removed request for
KazuCocoa and
mykola-mokhnach
lib/driver.js
Outdated
| const shouldEnableAnimation = isEnabled && !isAnimationOn; | ||
|
|
||
| if (shouldDisableAnimation) { | ||
| this.log.debug('Disabling window animation as "disableWindowAnimation" capability is set to true'); |
There was a problem hiding this comment.
it might not be necessarily set to true (e.g. if the default value is used)
There was a problem hiding this comment.
updated the message
mykola-mokhnach
approved these changes
Mar 3, 2023
README.md
Outdated
| @@ -179,6 +179,7 @@ appium:chromeOptions | A mapping, that allows to customize chromedriver options. | |||
| Capability Name | Description | |||
| --- | --- | |||
| appium:disableSuppressAccessibilityService | Being set to `true` tells the instrumentation process to not suppress accessibility services during the automated test. This might be useful if your automated test needs these services. `false` by default | |||
| appium:disableWindowAnimation | Disables the window animation for Android device under test. `true` by default | |||
There was a problem hiding this comment.
Perhaps it makes sense to describe in more details how enabling or disabling animations affects Espresso tests
There was a problem hiding this comment.
Added link for google espresso testing recommendation https://developer.android.com/training/testing/espresso/setup#set-up-environment
KazuCocoa
approved these changes
Mar 4, 2023
KazuCocoa
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Mar 13, 2023
## [2.17.0](v2.16.1...v2.17.0) (2023-03-13) ### Features * add disableWindowAnimation caps ([#857](#857)) ([eb4f60e](eb4f60e))
|
🎉 This PR is included in version 2.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #534 and makes animation configurable before launching the AUT.