-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: parse msedge as well as chromedriver #297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It probably also makes sense to mention the support of edge driver in README |
jlipps
reviewed
Apr 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree w/ @mykola-mokhnach's review
Test code format diff is by pretter automatically |
Updated ✅ |
mykola-mokhnach
approved these changes
Apr 13, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Apr 13, 2023
## [5.4.0](v5.3.4...v5.4.0) (2023-04-13) ### Features * parse msedge as well as chromedriver ([#297](#297)) ([a71240b](a71240b))
🎉 This PR is included in version 5.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appium/appium#18449
https://github.com/appium/appium-chromium-driver can work with MSEdge as well because the msedge driver also chromium driver, but one difference is the msedge driver prints the message as:
Current sync protocol refers to the output, so msedge always handles as MJSONWP. This PR tweaks the detection logic.
After this pr, https://github.com/appium/appium-chromium-driver will be able to handle edge as below:
example caps:
ms:edgeOptions
will be in the appium-chromium-driver side's handling.