Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamic gateway protobuf targets #622

Merged
merged 2 commits into from
Jan 3, 2017
Merged

dynamic gateway protobuf targets #622

merged 2 commits into from
Jan 3, 2017

Conversation

ndegory
Copy link
Contributor

@ndegory ndegory commented Jan 2, 2017

fixes #620

  • Makefile target list for gateway protobuf target is now dynamic

to test:

  • make clean
  • make proto
  • git status # workspace should be clean
  • make install

bquenin
bquenin approved these changes Jan 3, 2017
View reviewed changes
Copy link
Contributor

@bquenin bquenin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (tested on linux)

freignat91
freignat91 approved these changes Jan 3, 2017
View reviewed changes
Copy link
Contributor

@freignat91 freignat91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
tested ok

@freignat91 freignat91 merged commit 78b4a6a into master Jan 3, 2017
@freignat91 freignat91 deleted the cluster-proto branch January 3, 2017 14:10
@bquenin bquenin modified the milestone: 0.5.0 Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bquenin bquenin bquenin approved these changes

@freignat91 freignat91 freignat91 approved these changes

Assignees
No one assigned
Labels
kind/enhancement
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

New proto files are not automatically added to the Makefile proto rule
3 participants
@ndegory @bquenin @freignat91