Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

registry command #536

Merged
merged 1 commit into from
Dec 12, 2016
Merged

registry command #536

merged 1 commit into from
Dec 12, 2016

Conversation

ndegory
Copy link
Contributor

@ndegory ndegory commented Dec 9, 2016 •
edited
Loading

fixes #535

  • domain option applies to all registry commands
  • leverage the Docker API for push options
  • updated documentation with usage help

how to test:

  • make clean install
  • create a cluster with multiple nodes (you can use appcelerator/amp-swarm-deploy for that)
  • create an alias on route53 to point to an instance of the cluster (domain.com), with * subdomain CNAME
  • amp registry --domain domain.com ls # should return an empty array
  • amp registry --domain domain.com push an_image # should tag and push to the cluster registry
  • amp registry --domain domain.com ls # should return an array with the image just pushed

@ndegory ndegory self-assigned this Dec 9, 2016
@ndegory ndegory added this to the 0.4.0 milestone Dec 9, 2016
@ndegory ndegory changed the title WIP: registry command registry command Dec 12, 2016
freignat91
freignat91 approved these changes Dec 12, 2016
View reviewed changes
Copy link
Contributor

@freignat91 freignat91 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested ok
The PR is ok, but i going to open an issue on the --domain argument usage #540

@freignat91 freignat91 merged commit 5b45dc3 into master Dec 12, 2016
@freignat91 freignat91 deleted the issue-535 branch December 12, 2016 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freignat91 freignat91 freignat91 approved these changes

Assignees

@ndegory ndegory

Labels
area/cli area/docs
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

AMP registry not reachable remotely
2 participants
@ndegory @freignat91