-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revendoring (#500, part 1) #501
Conversation
the change on platform_manager.go is not working, amp pf start can't find the images. |
Yeah I had the same issue while testing |
I've included a workaround on the amp pf start issue (a new reference filter in the ImageList API not accepted by Docker 1.12). The tests are now passing. |
My preference would be to wait for docker 1.13 to be released and then update our vendors. |
Checking with the Docker people if it's a normal behavior of the library... |
we should wait for Docker 1.13 RC3: moby/moby#28895 |
The issue is fixed in Docker repo branch 1.13.x, I used it for the vendors, it works great now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #500
Still in progress: wait for Docker 1.13.0 rc3 for a fix on the API.
How to test: