Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revendoring (#500, part 1) #501

Merged
merged 3 commits into from
Dec 1, 2016
Merged

Revendoring (#500, part 1) #501

merged 3 commits into from
Dec 1, 2016

Conversation

ndegory
Copy link
Contributor

@ndegory ndegory commented Nov 24, 2016

Fixes #500

Still in progress: wait for Docker 1.13.0 rc3 for a fix on the API.

  • update the glide.yaml for better management of vendors (depending on a master branch is not stable)
  • update AMP code to adjust to the changes
  • update the glide.lock and the vendor (beware, big diff)

How to test:

  • make install
  • amp pf pull --local
  • amp pf start --local
  • make test
  • cli test

@ndegory
Copy link
Contributor Author

ndegory commented Nov 24, 2016

the change on platform_manager.go is not working, amp pf start can't find the images.

@ndegory ndegory added this to the 0.4.0 milestone Nov 24, 2016
@bquenin
Copy link
Contributor

bquenin commented Nov 25, 2016

Yeah I had the same issue while testing

@ndegory
Copy link
Contributor Author

ndegory commented Nov 26, 2016

I've included a workaround on the amp pf start issue (a new reference filter in the ImageList API not accepted by Docker 1.12). The tests are now passing.
I leave to the reviewers the decision to include or not the Docker vendoring commit.

@bquenin
Copy link
Contributor

bquenin commented Nov 26, 2016

My preference would be to wait for docker 1.13 to be released and then update our vendors.

@ndegory ndegory changed the title WIP: Revendoring (#500) Revendoring (#500) Nov 26, 2016
@ndegory
Copy link
Contributor Author

ndegory commented Nov 28, 2016

Checking with the Docker people if it's a normal behavior of the library...

@ndegory
Copy link
Contributor Author

ndegory commented Nov 29, 2016

we should wait for Docker 1.13 RC3: moby/moby#28895

@ndegory
Copy link
Contributor Author

ndegory commented Dec 1, 2016

The issue is fixed in Docker repo branch 1.13.x, I used it for the vendors, it works great now!

Copy link
Contributor

@freignat91 freignat91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@freignat91 freignat91 merged commit ede3fce into master Dec 1, 2016
@freignat91 freignat91 deleted the revendor branch December 1, 2016 10:06
@ndegory ndegory changed the title Revendoring (#500) Revendoring (#500, part 1) Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable vendor dependencies
3 participants