Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'make install' takes too long time (more than 30 secs) #658

Closed
bquenin opened this issue Jan 9, 2017 · 6 comments · Fixed by #664
Closed

'make install' takes too long time (more than 30 secs) #658

bquenin opened this issue Jan 9, 2017 · 6 comments · Fixed by #664

Comments

@bquenin
Copy link
Contributor

bquenin commented Jan 9, 2017

No description provided.

@subfuzion
Copy link
Contributor

I can't stand how long it takes either and started working on a fix yesterday as well. I should have created an issue for it. I'm killing two birds at once -- a faster build just for amplifier and the cli and having amp cli run in a container attached to amplifier's overlay network. I'm updating docker/gotools right now. The builder will bind mount the local files plus glide for a faster(er) build.

@bquenin
Copy link
Contributor Author

bquenin commented Jan 9, 2017

Great minds come together :) I'll close my PR then!

@subfuzion
Copy link
Contributor

subfuzion commented Jan 9, 2017

Hehe, more like frustrated minds :p ... I don't know that you need to close your PR just yet. Let's chew on it together with @ndegory.

@subfuzion
Copy link
Contributor

All I'm doing is adding an optimized build specifically for local development. I'm creating a single all-in-one go build tools image that includes everything we want for building, linting, generating protobuf files, etc, plus an optimizing the way we build/launch the cli during local development.

@subfuzion
Copy link
Contributor

Oops, too late ... ok, i guess we'll potentially reopen your PR after discussion...

@ndegory
Copy link
Contributor

ndegory commented Jan 10, 2017

I guess from what I read that we can gain from both PR. I'll review Bertrand's one, and I'll make another one to add to the frustration :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants