Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer+npm: increase range of engines to support Node.js 17 #993

Closed
abernix opened this issue Feb 11, 2022 · 0 comments · Fixed by #999, #1000 or #1003
Closed

installer+npm: increase range of engines to support Node.js 17 #993

abernix opened this issue Feb 11, 2022 · 0 comments · Fixed by #999, #1000 or #1003
Assignees
Milestone

Comments

@abernix
Copy link
Member

abernix commented Feb 11, 2022

Currently, we're limiting the engines range on the npm installer for @apollo/rover to Node.js 14 through 16:

"engines": {
"node": ">=14 <17",
"npm": ">=6"
},

On our other projects we somewhat heavily rely on the Node.js runtime and we want to be careful about experimental standard APIs and their changes. However, this @apollo/rover package is really just a very slim wrapper and our usage of the Node.js standard library is ... it looks like just using os:

const type = os.type();
const architecture = os.arch();

It would honestly be somewhat shocking if that API was broken in any Node.js version ever (touches wood), so I think we can even allow experimental versions when they become available.

Put another way, I think we can actually raise this to 17 already, and potentially even have Renovate automatically bump it to the latest release (in this particular package.json!)

Thoughts?

@abernix abernix added maintenance 🛠️ triage issues and PRs that need to be triaged labels Feb 11, 2022
@abernix abernix changed the title installer+npm: increase range of engines to support newer Node.js versions installer+npm: increase range of engines to support Node.js 17 Feb 11, 2022
@EverlastingBugstopper EverlastingBugstopper added this to the 0.4.2 milestone Feb 11, 2022
This was referenced Feb 11, 2022
@abernix abernix removed the triage issues and PRs that need to be triaged label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment