You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On our other projects we somewhat heavily rely on the Node.js runtime and we want to be careful about experimental standard APIs and their changes. However, this @apollo/rover package is really just a very slim wrapper and our usage of the Node.js standard library is ... it looks like just using os:
It would honestly be somewhat shocking if that API was broken in any Node.js version ever (touches wood), so I think we can even allow experimental versions when they become available.
Put another way, I think we can actually raise this to 17 already, and potentially even have Renovate automatically bump it to the latest release (in this particular package.json!)
Thoughts?
The text was updated successfully, but these errors were encountered:
abernix
changed the title
installer+npm: increase range of engines to support newer Node.js versions
installer+npm: increase range of engines to support Node.js 17
Feb 11, 2022
Currently, we're limiting the
engines
range on the npm installer for@apollo/rover
to Node.js 14 through 16:rover/installers/npm/package.json
Lines 30 to 33 in 6515eb3
On our other projects we somewhat heavily rely on the Node.js runtime and we want to be careful about experimental standard APIs and their changes. However, this
@apollo/rover
package is really just a very slim wrapper and our usage of the Node.js standard library is ... it looks like just usingos
:rover/installers/npm/binary.js
Lines 43 to 44 in 6515eb3
It would honestly be somewhat shocking if that API was broken in any Node.js version ever (touches wood), so I think we can even allow experimental versions when they become available.
Put another way, I think we can actually raise this to
17
already, and potentially even have Renovate automatically bump it to the latest release (in this particularpackage.json
!)Thoughts?
The text was updated successfully, but these errors were encountered: