Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: rover is built on centos 7 but... can't run on centos 7?? #991

Closed
EverlastingBugstopper opened this issue Feb 9, 2022 · 1 comment · Fixed by #990 or #1003
Closed

bug: rover is built on centos 7 but... can't run on centos 7?? #991

EverlastingBugstopper opened this issue Feb 9, 2022 · 1 comment · Fixed by #990 or #1003
Labels
Milestone

Comments

@EverlastingBugstopper
Copy link
Contributor

EverlastingBugstopper commented Feb 9, 2022

if you try to install rover on centos 7, you'll get an error telling you that you can't because Rover needs glibc 2.18.

$ npx -p @apollo/rover rover supergraph compose
This operating system needs glibc >= 2.18, but only has 2.17 installed.
Downloading musl binary that does not include `rover supergraph compose`.
This operating system needs glibc >= 2.18, but only has 2.17 installed.
Downloading musl binary that does not include `rover supergraph compose`.
error: This version of Rover does not support this command.
        This is likely an issue with your current version of `glibc`. Try running `ldd --version`, and if the version >= 2.18, we suggest installing the Rover binary built for `x86_64-unknown-linux-gnu

this is a bald faced lie! we build rover's binaries on centos 7! what gives?

turns out, once we moved from ubuntu 16 to centos 7 we didn't need to require version 2.18, only 2.17. we added nice error handling so folks with glibc under our required version would safely download the musl version (which unfortunately doesn't include supergraph compose because it relies on deno_core which still can't be built on musl. however, for folks with version 2.17 this "helpful" behavior becomes not so helpful because our prebuilt binaries would work, but our installer scripts don't think it will.

This is all quite confusing and should be fixed by lowering the required glibc version from 2.18 to 2.17.


thanks to @theJC from Indeed for the report!

@EverlastingBugstopper EverlastingBugstopper added bug 🐞 triage issues and PRs that need to be triaged and removed triage issues and PRs that need to be triaged labels Feb 9, 2022
@EverlastingBugstopper EverlastingBugstopper added this to the 0.4.2 or 0.5.0 milestone Feb 9, 2022
@theJC
Copy link

theJC commented Feb 14, 2022

Still exhibiting the same issue in 0.4.2

bash-4.2$ npx -p @apollo/[email protected] rover supergraph compose
This operating system does not support dynamic linking to glibc.
Downloading musl binary that does not include `rover supergraph compose`.
This operating system does not support dynamic linking to glibc.
Downloading musl binary that does not include `rover supergraph compose`.
error: This version of Rover does not support this command.
        This is likely an issue with your current version of `glibc`. Try running `ldd --version`, and if the version >= 2.17, we suggest installing the Rover binary built for `x86_64-unknown-linux-gnu`
bash-4.2$ ldd --version
ldd (GNU libc) 2.17
Copyright (C) 2012 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Written by Roland McGrath and Ulrich Drepper.
bash-4.2$ cat /etc/centos-release
CentOS Linux release 7.9.2009 (Core)
bash-4.2$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants