Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.1.1 - non-federated graph errors for previously functioning subgraph checks #553

Closed
setchy opened this issue May 20, 2021 · 2 comments · Fixed by #555
Closed

v0.1.1 - non-federated graph errors for previously functioning subgraph checks #553

setchy opened this issue May 20, 2021 · 2 comments · Fixed by #555
Labels

Comments

@setchy
Copy link
Contributor

setchy commented May 20, 2021

Description

Since the release of @rover 0.1.1 today, we've had errors for any new rover subgraph check commands as executed via Bitbucket Pipelines. These commands have been working fine without error on many previous versions of rover and are identical to the steps documented under Rover Bitbucket Pipelines

Steps to reproduce

Run a rover subgraph check {graph-name}@{variant-name} --name {subgraph-name} --schema {schema-path}

Expected result

Checked the proposed subgraph against _xxxx@prod_
Compared _y_ schema changes against _z_ operations

Actual result

error[E007]: The graph `xxxx@prod` is a non-federated graph. This operation is only possible for federated graphs.
              Try running the command on a valid federated graph, or use the appropriate `rover graph` command instead of `rover subgraph`.

Environment

Run rover info and paste the results here

If you can't run rover info for some reason, please provide as much of the following info as possible:

  • Operating system and version: 🤷‍♂️ bitbucket pipelines
  • Shell (bash/zsh/powershell): 🤷 bitbucket pipelines
  • Version of Rover (rover --help): 0.1.1
  • Apollo Studio Plan: enterprise
  • Installation method: npx -p
@setchy setchy added bug 🐞 triage issues and PRs that need to be triaged labels May 20, 2021
@setchy setchy changed the title v0.1.1 - v0.1.1 - non-federated graph errors for previously functioning subgraph checks May 20, 2021
@setchy
Copy link
Contributor Author

setchy commented May 20, 2021

Some further info from my local machine

rover info

user@machine ~ % rover info
Rover Info:
Version: 0.1.0
Install Location: /Users/user/.nvm/versions/node/v14.16.1/lib/node_modules/@apollo/rover/node_modules/binary-install/bin/rover
OS: Mac OS 11.3.0 [64-bit]
Shell: /bin/zsh

rover subgraph check on v0.1.0

user@machine  % rover subgraph check graph-name@variant-name --name subgraph-name --schema ./schema.graphqls

Checked the proposed subgraph against graph-name@variant-name
Compared 15 schema changes against 34 operations

Update rover from v0.1.0 to v0.1.1

user@machine ~ % npm -g install @apollo/[email protected]

added 1 package, changed 28 packages, and audited 30 packages in 10s

3 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

rover info one more time, to be sure

user@machine ~ % rover info
Rover Info:
Version: 0.1.1
Install Location: /Users/user/.nvm/versions/node/v14.16.1/lib/node_modules/@apollo/rover/node_modules/binary-install/bin/rover
OS: Mac OS 11.3.0 [64-bit]
Shell: /bin/zsh

Run same rover subgraph check as before, but on v0.1.1

user@machine % rover subgraph check graph-name@variant-name --name subgraph-name --schema ./schema.graphqls

error[E007]: The graph `graph-name` is a non-federated graph. This operation is only possible for federated graphs.
              Try running the command on a valid federated graph, or use the appropriate `rover graph` command instead of `rover subgraph`.

@lrlna
Copy link
Member

lrlna commented May 20, 2021

hi @setchy ! Thanks so much for the report. Are you able to run this command with --log trace and share the last 10 or so entries before you get the error?

@abernix abernix removed the triage issues and PRs that need to be triaged label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants