Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify styling of composition errors #508

Closed
EverlastingBugstopper opened this issue May 5, 2021 · 0 comments · Fixed by #557
Closed

Unify styling of composition errors #508

EverlastingBugstopper opened this issue May 5, 2021 · 0 comments · Fixed by #557
Assignees
@EverlastingBugstopper
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Milestone
August 2

Comments

@EverlastingBugstopper
Copy link
Contributor

EverlastingBugstopper commented May 5, 2021 •
edited
Loading 

$ rover supergraph compose --config supergraph.yml         
error: UNKNOWN
error: UNKNOWN: Unknown type "Personnnn". Did you mean "Person"?
error: UNKNOWN: Type Query must define one or more fields.
error: Encountered 3 composition errors while composing the graph.

vs.

$ rover subgraph check supergraph --name films --schema films.graphql
Checked the proposed subgraph against supergraph@current
error: Unknown type: "Personnnn".
error: Unknown type "Personnnn". Did you mean "Person"?
error: Type Query must define one or more fields.
error: Encountered 3 composition errors while composing the subgraph.

^ IMO these should look exactly the same
@EverlastingBugstopper EverlastingBugstopper added the triage issues and PRs that need to be triaged label May 5, 2021
Merged
Merged
@abernix abernix removed the triage issues and PRs that need to be triaged label Jul 21, 2021
@abernix abernix added this to the ~ July 27 milestone Jul 21, 2021
@abernix abernix added the feature 🎉 new commands, flags, functionality, and improved error messages label Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EverlastingBugstopper EverlastingBugstopper

Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Milestone
August 2
Development

Successfully merging a pull request may close this issue.

chore: refactor rover-client in pursuit of structured output apollographql/rover
2 participants
@abernix @EverlastingBugstopper