wip

Author: JakeDawkins

.vscode/launch.json

@@ -0,0 +1,16 @@
+{
+  // Use IntelliSense to learn about possible attributes.
+  // Hover to view descriptions of existing attributes.
+  // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+  "version": "0.2.0",
+  "configurations": [
+    {
+      "type": "lldb",
+      "request": "launch",
+      "name": "Debug",
+      "program": "${workspaceFolder}/<your program>",
+      "args": [],
+      "cwd": "${workspaceFolder}"
+    }
+  ]
+}

Cargo.lock

@@ -14,6 +14,7 @@ serde = "1"
 serde_json = "1"
 thiserror = "1"
 tracing = "0.1"
+chrono = "0.4"
 
 [build-dependencies]
 online = "0.2.2"

crates/rover-client/Cargo.toml

@@ -42,7 +42,7 @@ pub fn run(
     let root_url = response_data.frontend_url_root.clone();
     let subgraphs = get_subgraphs_from_response_data(response_data, &graph_name)?;
     Ok(ListDetails {
-        subgraphs: format_subgraphs(subgraphs),
+        subgraphs: format_subgraphs(&subgraphs),
         root_url,
         graph_name,
     })
@@ -83,7 +83,7 @@ fn get_subgraphs_from_response_data(
 
 /// puts the subgraphs into a vec of SubgraphInfo, sorted by updated_at
 /// timestamp. Newer updated services will show at top of list
-fn format_subgraphs(subgraphs: Vec<RawSubgraphInfo>) -> Vec<SubgraphInfo> {
+fn format_subgraphs(subgraphs: &[RawSubgraphInfo]) -> Vec<SubgraphInfo> {
     let mut subgraphs: Vec<SubgraphInfo> = subgraphs
         .iter()
         .map(|subgraph| SubgraphInfo {

crates/rover-client/src/query/subgraph/list.rs

@@ -48,11 +48,11 @@ impl RoverStdout {
                 table.add_row(row!["Name", "Routing Url", "Last Updated"]);
 
                 for subgraph in &details.subgraphs {
-                    table.add_row(row![
-                        subgraph.name,
-                        subgraph.url.clone().unwrap_or_else(|| "".to_string()),
-                        subgraph.updated_at
-                    ]);
+                    // if the url is None or empty (""), then set it to "N/A"
+                    let url = subgraph.url.clone().unwrap_or_else(|| "N/A".to_string());
+                    let url = if url == "" { "N/A".to_string() } else { url };
+
+                    table.add_row(row![subgraph.name, url, subgraph.updated_at]);
                 }
 
                 println!("{}", table);