Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for unexpectedErrorProcessingRequest #6848

Open
trevor-scheer opened this issue Aug 24, 2022 · 3 comments
Open

Add tests for unexpectedErrorProcessingRequest #6848

trevor-scheer opened this issue Aug 24, 2022 · 3 comments
Assignees
@trevor-scheer
Labels
🧪 testing

Comments

@trevor-scheer
Copy link
Member

Some additional context here:
#6846 (comment)

We can exercise this hook a few ways, but in particular we should make sure that this hook is called when a different end hook throws.

i.e. parsing fails
parsingDidEnd hook throws
expect unexpectedErrorProcessingRequest to be called

Same for execution and validation as well.
@trevor-scheer trevor-scheer added this to the Release 4.0 milestone Aug 24, 2022
@trevor-scheer trevor-scheer self-assigned this Aug 24, 2022
@glasser
Copy link
Member

glasser commented Sep 27, 2022

post-RC OK

@trevor-scheer
Copy link
Member Author

We also have no tests for didEncounterSubsequentErrors and willSendSubsequentPayload

@glasser glasser removed this from the Release 4.0 milestone Nov 22, 2022
@glasser
Copy link
Member

glasser commented Nov 22, 2022

Removing from milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trevor-scheer trevor-scheer

Labels
🧪 testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@glasser @trevor-scheer