-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reFetchObservableQueries should not refetch skipped queries #7146
Conversation
@joshjg: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Elegant! I bumped the bundlesize
limit in 28808ce to fix the tests, so no need to worry about that.
@joshjg This change has been published in |
@benjamn Thank you so much for the quick turnaround! |
@joshjg @benjamn I think we need to add this change here as well to prevent refetching queries that should be skipped following a mutation: on main: apollo-client/src/core/QueryManager.ts Lines 274 to 275 in 49b45e3
Filed this PR: |
Fixes #6154, Fixes #7113, Fixes #7145
Checklist: