Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reFetchObservableQueries should not refetch skipped queries #7146

Merged
merged 2 commits into from
Oct 13, 2020

Conversation

joshjg
Copy link
Contributor

@joshjg joshjg commented Oct 10, 2020

Fixes #6154, Fixes #7113, Fixes #7145

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@joshjg: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant! I bumped the bundlesize limit in 28808ce to fix the tests, so no need to worry about that.

@benjamn
Copy link
Member

benjamn commented Oct 13, 2020

@joshjg This change has been published in @apollo/[email protected] and @apollo/[email protected], jfyi.

@joshjg
Copy link
Contributor Author

joshjg commented Oct 13, 2020

@benjamn Thank you so much for the quick turnaround!

@dannycochran
Copy link
Contributor

@joshjg @benjamn I think we need to add this change here as well to prevent refetching queries that should be skipped following a mutation:

on main:

if (observableQuery &&
observableQuery.queryName === refetchQuery) {

Filed this PR:
#7877

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants