From 1cea0cae1ac1b0d13a35a32caf87a03de4320875 Mon Sep 17 00:00:00 2001 From: Lenz Weber-Tronic <lorenz.weber-tronic@apollographql.com> Date: Tue, 28 Jan 2025 14:20:19 +0100 Subject: [PATCH] some more knip reportings --- knip.config.js | 2 +- src/testing/internal/renderHelpers.tsx | 53 -------------------------- src/testing/react/MockedProvider.tsx | 2 +- 3 files changed, 2 insertions(+), 55 deletions(-) diff --git a/knip.config.js b/knip.config.js index eb80892ab7d..1b13b391b80 100644 --- a/knip.config.js +++ b/knip.config.js @@ -29,7 +29,7 @@ const config = { "src/react/types/types.documentation.ts", "eslint-local-rules/index.js", ]), - project: ["src/**/*.ts", "config/*.[jt]s", "eslint-local-rules/*.[jt]s"], + project: ["src/**/*.ts{,x}", "config/*.[jt]s", "eslint-local-rules/*.[jt]s"], ignore: ["integration-tests/**/*", ".yalc/**/*"], ignoreBinaries: ["jq"], ignoreDependencies: [ diff --git a/src/testing/internal/renderHelpers.tsx b/src/testing/internal/renderHelpers.tsx index de744abff6c..077c2fdc1ae 100644 --- a/src/testing/internal/renderHelpers.tsx +++ b/src/testing/internal/renderHelpers.tsx @@ -1,20 +1,9 @@ import * as React from "react"; -import type { ReactElement } from "react"; -import { render } from "@testing-library/react"; -import type { Queries, RenderOptions, queries } from "@testing-library/react"; import type { ApolloClient } from "../../core/index.js"; import { ApolloProvider } from "../../react/index.js"; import type { MockedProviderProps } from "../react/MockedProvider.js"; import { MockedProvider } from "../react/MockedProvider.js"; -export interface RenderWithClientOptions< - Q extends Queries = typeof queries, - Container extends Element | DocumentFragment = HTMLElement, - BaseElement extends Element | DocumentFragment = Container, -> extends RenderOptions<Q, Container, BaseElement> { - client: ApolloClient<any>; -} - export function createClientWrapper( client: ApolloClient<any>, Wrapper: React.JSXElementConstructor<{ @@ -32,31 +21,6 @@ export function createClientWrapper( }; } -export function renderWithClient< - Q extends Queries = typeof queries, - Container extends Element | DocumentFragment = HTMLElement, - BaseElement extends Element | DocumentFragment = Container, ->( - ui: ReactElement, - { - client, - wrapper, - ...renderOptions - }: RenderWithClientOptions<Q, Container, BaseElement> -) { - return render(ui, { - ...renderOptions, - wrapper: createClientWrapper(client, wrapper), - }); -} - -export interface RenderWithMocksOptions< - Q extends Queries = typeof queries, - Container extends Element | DocumentFragment = HTMLElement, - BaseElement extends Element | DocumentFragment = Container, -> extends RenderOptions<Q, Container, BaseElement>, - MockedProviderProps<any> {} - export function createMockWrapper( renderOptions: MockedProviderProps<any>, Wrapper: React.JSXElementConstructor<{ @@ -73,20 +37,3 @@ export function createMockWrapper( ); }; } - -export function renderWithMocks< - Q extends Queries = typeof queries, - Container extends Element | DocumentFragment = HTMLElement, - BaseElement extends Element | DocumentFragment = Container, ->( - ui: ReactElement, - { - wrapper, - ...renderOptions - }: RenderWithMocksOptions<Q, Container, BaseElement> -) { - return render(ui, { - ...renderOptions, - wrapper: createMockWrapper(renderOptions, wrapper), - }); -} diff --git a/src/testing/react/MockedProvider.tsx b/src/testing/react/MockedProvider.tsx index fa06db3c324..c5a23dc0020 100644 --- a/src/testing/react/MockedProvider.tsx +++ b/src/testing/react/MockedProvider.tsx @@ -27,7 +27,7 @@ export interface MockedProviderProps<TSerializedCache = {}> { connectToDevTools?: boolean; } -export interface MockedProviderState { +interface MockedProviderState { client: ApolloClient<any>; }