Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollo Client keeps the list of all executed mutations in mutationStore and never cleans it #7616

Closed
smykhailov opened this issue Jan 26, 2021 · 2 comments

Comments

@smykhailov
Copy link

Each executed mutation stays in the mutationStore forever, it might cause memory leaks.
Apollo needs to clean the mutationStore records when mutations is done.

@benjamn
Copy link
Member

benjamn commented Jan 26, 2021

@smykhailov Starting in @apollo/[email protected], thanks to commit ad4be6e in #7161, we no longer create the queryManager.mutationStore unless it's being used by devtools, so I think this may not be a problem any longer, if you update?

@smykhailov
Copy link
Author

Thank you @benjamn, we use it in our custom DevTools and realized this problem. Great to hear it doesn't cause any issue in production code. You can close the issue, we can manage this in our DevTools by ourselves.

@benjamn benjamn closed this as completed Jan 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants