From 18b091241661e2355746eb72142b1b72c6a9d6d7 Mon Sep 17 00:00:00 2001 From: Ben Newman Date: Thu, 16 Jul 2020 18:35:55 -0400 Subject: [PATCH] Remove stripFns, now that @wry/equality handles functions better. --- src/react/data/QueryData.ts | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/src/react/data/QueryData.ts b/src/react/data/QueryData.ts index d0b3e2acb67..898cc74099f 100644 --- a/src/react/data/QueryData.ts +++ b/src/react/data/QueryData.ts @@ -27,8 +27,6 @@ import { } from '../types/types'; import { OperationData } from './OperationData'; -const stripFns = ({ onCompleted, onError, ...rest }: any = {}) => rest; - export class QueryData extends OperationData { public onNewData: () => void; @@ -241,15 +239,12 @@ export class QueryData extends OperationData { children: null }; - // When comparing new options against previously stored options, - // we'll ignore callback functions since their identities are not - // stable, meaning they'll always show as being different. Ignoring - // them when determining if options have changed is okay however, as - // callback functions are not normally changed between renders. - if (!equal( - stripFns(newObservableQueryOptions), - stripFns(this.previousData.observableQueryOptions), - )) { + if ( + !equal( + newObservableQueryOptions, + this.previousData.observableQueryOptions + ) + ) { this.previousData.observableQueryOptions = newObservableQueryOptions; this.currentObservable .setOptions(newObservableQueryOptions)