Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update angular monorepo to v8 (major) #1206

Merged
merged 4 commits into from
May 29, 2019
Merged

chore(deps): update angular monorepo to v8 (major) #1206

merged 4 commits into from
May 29, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 29, 2019

This PR contains the following updates:

Package Type Update Change References
@​angular/animations devDependencies major 7.2.13 -> 8.0.0 source
@​angular/common devDependencies major 7.2.13 -> 8.0.0 source
@​angular/common peerDependencies major [`^6.0.0
@​angular/compiler devDependencies major 7.2.13 -> 8.0.0 source
@​angular/compiler-cli devDependencies major 7.2.13 -> 8.0.0 source
@​angular/core peerDependencies major [`^6.0.0
@​angular/core devDependencies major 7.2.13 -> 8.0.0 source
@​angular/platform-browser devDependencies major 7.2.13 -> 8.0.0 source
@​angular/platform-browser-dynamic devDependencies major 7.2.13 -> 8.0.0 source
@​angular/platform-server devDependencies major 7.2.13 -> 8.0.0 source

Release Notes

angular/angular

v8.0.0

Compare Source

Features
Bug Fixes
DEPRECATIONS
BREAKING CHANGES

  • bazel: @​bazel/typescript is now a peerDependency of @​angular/bazel so user's of @​angular/bazel must add @​bazel/typescript to their package.json

  • bazel: ng_module now depends on a minimum of build_bazel_rules_nodejs 0.27.12

  • core: In Angular version 8, it's required that all @​ViewChild and @​ContentChild
    queries have a 'static' flag specifying whether the query is 'static' or
    'dynamic'. The compiler previously sorted queries automatically, but in
    8.0 developers are required to explicitly specify which behavior is wanted.
    This is a temporary requirement as part of a migration; see
    https://v8.angular.io/guide/static-query-migration for more details.

    @​ViewChildren and @​ContentChildren queries are always dynamic, and so are
    unaffected.

  • TestBed.get() has two signatures, one which is typed and another which accepts and returns any. The signature for any is deprecated; all usage of TestBed.get() should go through the typed API. This mainly affects string tokens
    (which aren't supported) and abstract class tokens.

    Before:

    TestBed.configureTestingModule({
  providers: [{provide: "stringToken", useValue: new Service()}],
});

let service = TestBed.get("stringToken"); // type any

    After:

    const SERVICE_TOKEN = new InjectionToken<Service>("SERVICE_TOKEN");

TestBed.configureTestingModule({
  providers: [{provide: SERVICE_TOKEN, useValue: new Service()}],
});

let service = TestBed.get(SERVICE_TOKEN); // type Service

  • core: Certain elements (like <tr> or <col>) require parent elements to be of a certain type by the HTML specification
    (ex. <tr> can only be inside <tbody> / <thead>). Before this change Angular template parser was auto-correcting
    "invalid" HTML using the following rules:

    • <tr> would be wrapped in <tbody> if not inside <tbody>, <tfoot> or <thead>;

    • <col> would be wrapped in <colgroup> if not inside <colgroup>.

      This meachanism of automatic wrapping / auto-correcting was problematic for several reasons:

    • it is non-obvious and arbitrary (ex. there are more HTML elements that has rules for parent type);

    • it is incorrect for cases where <tr> / <col> are at the root of a component's content, ex.:

      <projecting-tr-inside-tbody>
  <tr>...</tr>
</projecting-tr-inside-tbody>

      In the above example the <projecting-tr-inside-tbody> component could be "surprised" to see additional
      <tbody> elements inserted by Angular HTML parser.

  • TypeScript 3.1 and 3.2 are no longer supported.

    Please update your TypeScript version to 3.3

v7.2.15

Compare Source

Bug Fixes

v7.2.14

Compare Source

Bug Fixes

Renovate configuration

📅 Schedule: "after 11pm every weekday,before 6am every weekday" in timezone Europe/Warsaw.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot requested a review from kamilkisiela May 29, 2019 00:17
@stunti stunti mentioned this pull request May 29, 2019
Closed
@renovate
Copy link
Contributor Author

renovate bot commented May 29, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@kamilkisiela kamilkisiela merged commit 9a86be1 into master May 29, 2019
@kamilkisiela kamilkisiela deleted the renovate/major-angular-monorepo branch May 29, 2019 18:59
@github-actions github-actions bot mentioned this pull request Feb 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilkisiela kamilkisiela Awaiting requested review from kamilkisiela

Assignees

@kamilkisiela kamilkisiela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamilkisiela @renovate-bot