Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to upgrade cheerio from v1.0.0-rc.12 to v1.0.0 #2852

Open
bossp888 opened this issue Feb 19, 2025 · 1 comment
Open

Any plan to upgrade cheerio from v1.0.0-rc.12 to v1.0.0 #2852

bossp888 opened this issue Feb 19, 2025 · 1 comment
Labels
feature Issues that represent new features or improvements to existing features. t-tooling Issues with this label are in the ownership of the tooling team.
Milestone

Comments

@bossp888
Copy link

Which package is the feature request for? If unsure which one to select, leave blank

@crawlee/cheerio (CheerioCrawler)

Feature

Hi crawlee team,

I noticed that crawlee currently depends on cheerio v1.0.0-rc.12, which was released on Jun 26, 2022. The latest stable version of cheerio, v1.0.0, was released on Aug 10, 2024.

I'd like to request an upgrade to the cheerio dependency.

Motivation

I'd like to request an upgrade to the cheerio dependency. Using the latest version offers several potential benefits, including:

  • Bug fixes: The newer version likely includes fixes for bugs present in the older release candidate.
  • Performance improvements: Optimizations and performance enhancements may have been implemented in the newer version.
  • Security updates: Security vulnerabilities identified in the older version may have been addressed in the latest release.
  • New features: The latest version might introduce new features or functionalities that could be beneficial to crawlee.

Ideal solution or implementation, and any additional constraints

The ideal solution would be to update the cheerio dependency in crawlee to the latest stable version (v1.0.0 or later). This can be achieved by modifying the package.json file and running the appropriate dependency update command (e.g., npm install cheerio@latest or yarn upgrade cheerio).

Alternative solutions or implementations

No response

Other context

No response

@bossp888 bossp888 added the feature Issues that represent new features or improvements to existing features. label Feb 19, 2025
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Feb 19, 2025
@janbuchar
Copy link
Contributor

Hello! We tried upgrading to 1.0 a while back, but it looks like there were some breaking changes since rc12, which broke our tests.

It is likely that we will attempt the upgrade again for Crawlee 4.0.

@janbuchar janbuchar added this to the 4.0 milestone Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issues that represent new features or improvements to existing features. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

2 participants