Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving QueuedActorClient.call when bundle is being aborted gracefully #2

Open
oklinov opened this issue Sep 25, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@oklinov
Copy link

oklinov commented Sep 25, 2024

Let's say my bundle uses abortAllRunsOnGracefulAbort = true and receives aborting signal (it's gracefully aborted) while it's waiting for a contact-info-scraper run to finish:

const cdsRun = await this.client.actor('vdrmota/contact-info-scraper').call(`CDS-0`, { ... });

Currently the call method returns ActorRun with status === 'ABORTED'. IMO the call method should not return anything (it should sleep until the abort) if a bundle was aborted by the library. Otherwise the dev needs to handle two kinds of 'ABORTED': 1) aborted by the library 2) aborted by a user

@gullmar gullmar added the enhancement New feature or request label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants